Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent file upload when folder creation failed #7975

Merged
merged 3 commits into from
Nov 18, 2022

Conversation

JammingBen
Copy link
Collaborator

@JammingBen JammingBen commented Nov 15, 2022

Description

We've fixed a bug where files would try to be uploaded if the creation of their respective folder failed beforehands.

Also improved the tests a bit:

  • Converted the tests for CreateAndUpload to TypeScript
  • Removed the upload helper tests from the component and moved them into a separate test suite

Related Issue

Screenshots

Upload failed

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen added the Type:Bug Something isn't working label Nov 15, 2022
@JammingBen JammingBen self-assigned this Nov 15, 2022
@JammingBen JammingBen marked this pull request as ready for review November 16, 2022 10:38
@ownclouders
Copy link
Contributor

ownclouders commented Nov 16, 2022

Results for oC10SharingPublic2 https://drone.owncloud.com/owncloud/web/29901/37/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingPublicExpire-shareByPublicLinkExpiringLinks_feature-L62.png

webUISharingPublicExpire-shareByPublicLinkExpiringLinks_feature-L62.png

💥 The oC10SharingPublic2 tests pipeline failed. The build has been cancelled.

@JammingBen JammingBen changed the base branch from master to stable-6.0 November 17, 2022 09:18
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a typo in the changelog item, I can change that in another PR when I prepare the next rc tag.

@sonarcloud
Copy link

sonarcloud bot commented Nov 18, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@ScharfViktor
Copy link
Contributor

re-tested in rc2:

Screenshot 2022-11-28 at 18 03 04

@kulmann
Copy link
Member

kulmann commented Nov 28, 2022

re-tested in rc2:

Screenshot 2022-11-28 at 18 03 04

It's expected that this shows Unknown error. We can't bring new translation strings to the stable-6.0 branch for technical reasons. The current web master has a more specific error message for this error case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type:Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

web ui continues uploading a folder when receiving a 409
5 participants