Fix file versions on 'Shared with me'-page #7989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fyi: I don't want to go crazy on the unit tests here because they changed quite heavily on master. |
|
it seems the web ui is making a request that uses that url should be taken literally from the href: that uses downloading revisions also requires cs3org/reva#3473 |
This should be fixed with this PR. I'll test it when cs3org/reva#3473 is merged. |
kulmann
requested changes
Nov 21, 2022
packages/web-app-files/src/components/SideBar/Versions/FileVersions.vue
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed! |
dschmidt
approved these changes
Nov 24, 2022
| @@ -29,7 +29,7 @@ export default { | |||
| if (version === null) { | |||
| url = `${this.$client.helpers._davPath}${file.webDavPath}` | |||
| } else { | |||
| url = this.$client.fileVersions.getFileVersionUrl(file.id, version) | |||
| url = this.$client.fileVersions.getFileVersionUrl(file.fileId, version) | |||
| @@ -52,10 +52,10 @@ import { mapActions, mapGetters, mapMutations } from 'vuex' | |||
| import { DavProperty } from 'web-client/src/webdav/constants' | |||
| import { formatRelativeDateFromHTTP, formatFileSize } from 'web-pkg/src/helpers' | |||
| import { WebDAV } from 'web-client/src/webdav' | |||
| import { inject } from '@vue/composition-api' | |||
| import { defineComponent, inject } from '@vue/composition-api' | |||
There was a problem hiding this comment.
We need to be careful when merging to master later
kulmann
approved these changes
Nov 24, 2022
73 tasks
49 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Downloading and reverting versions on the "Shared with me"-page has been fixed.
Related Issue
Types of changes