-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[full-ci] Enhancement: Add whitespace context-menu #8921
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
56f9404
to
a4df0dd
Compare
packages/web-app-files/src/components/Spaces/SpaceGenericContextMenu.vue
Outdated
Show resolved
Hide resolved
Refactoring of the CreateAndUpload component into composables needed before this PR |
a4df0dd
to
1efaeba
Compare
ad8e843
to
abb0c1d
Compare
@kulmann to the first point yes i can do that, the second point: Did you try it in the space root? in subfolders it should work, my assumption was there is no detail on the e.g. personal space root? Or did i miss something? |
ah. uh. I think both of my findings were bogus...
For the personal space root it's a little bit confusing because the personal space doesn't have details. So that could be a tiny improvement: don't show the |
@kulmann alright shouldl be doable, the first point was right, i just fixed it ^^ |
packages/web-app-files/src/components/Spaces/SpaceGenericContextMenu.vue
Outdated
Show resolved
Hide resolved
packages/web-app-files/src/composables/actions/files/useFileActionsCreateNewFolder.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you decide to not use the ContextActionMenu.vue
component? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually you are right, was reverse engineering the context menu in order to understand it but didn't notice that I now can use the same component, wasn't clear if i would be able to use it at first
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but will try to use it, shouldn't be much difference between those two besides the sections
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
arg, my assumption was wrong, can't get the ContextActionMenu to work at this point because _tippy is always undefined, would rename it to WhitespaceContextMenu for now :/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't see how to quickly fix that, also there are some differences between those two component
packages/web-app-files/src/components/Spaces/SpaceGenericContextMenu.vue
Outdated
Show resolved
Hide resolved
packages/web-app-files/src/composables/actions/files/useFileActionsCreateNewFolder.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found two more things. Also, what about unit tests, at least for opening the whitespace context menu (not for the actions inside it)?
packages/web-app-files/src/composables/actions/files/useFileActionsCreateNewFolder.ts
Outdated
Show resolved
Hide resolved
@kulmann done |
SonarCloud Quality Gate failed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome stuff! Love the UX of this 😍
Description
We've added a generic context-menu for right clicking on whitespace.
See #5861
Related Issue
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: