Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remember location after token invalidation #9364

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

JammingBen
Copy link
Collaborator

Description

Fixes an issue where token invalidation in the IDP would result in losing the current location. So logging in after token invalidation now correctly redirects to the page the user was before.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen self-assigned this Jul 6, 2023
@JammingBen JammingBen mentioned this pull request Jun 30, 2023
37 tasks
Fixes an issue where token invalidation in the IDP would result in losing the current location. So logging in after token invalidation now correctly redirects to the page the user was before.
@JammingBen JammingBen force-pushed the remember-location-after-token-invalidation branch from 66a96ac to 9ebf5c3 Compare July 7, 2023 09:13
@sonarcloud
Copy link

sonarcloud bot commented Jul 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

12.5% 12.5% Coverage
0.0% 0.0% Duplication

@AlexAndBear AlexAndBear merged commit a7e6126 into master Jul 7, 2023
@delete-merged-branch delete-merged-branch bot deleted the remember-location-after-token-invalidation branch July 7, 2023 10:41
@tbsbdr tbsbdr added this to the CERN Web Merge milestone Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Access denied: Navigate to location from before after clicking login
3 participants