Theme names

[elizavetaRa]

Description

Adding the "theme name" property that should be visible for switcher of more than 2 themes
Relates to #9396

Related Issue

• Fixes Provide nicer-to-read names for themes #9403

Motivation and Context

How Has This Been Tested?

• test environment:
• test case 1:
• test case 2:
• ...

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:

Open tasks:

• ...

[update-docs]

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

[elizavetaRa]

@tbsbdr @pascalwengerter
To discuss: in the current implementation the keys "default" and "default-dark" for themes are handled as names in packages/web-runtime/src/composables/theme/useDefaultThemeName.ts. They are certainly not fitting as names to be shown for user.

• Could they be renamed to themeId or
• Or could we give more user-friendly strings for these keys like "Default light" and "Default dark"? Then there would be no need to add an extra-property

[dschmidt]

I think it's reasonable to have a technical and a user visible name - we just need to make sure the user visible strings are translated

[pascalwengerter]

I think it's reasonable to have a technical and a user visible name - we just need to make sure the user visible strings are translated

Translations are tough-to-impossible for custom themes though (unless I'm missing something)?
Agreed in general and happy to work on it in the upcoming weeks (but after the CERN bucket list?)

[dschmidt]

I think it's reasonable to have a technical and a user visible name - we just need to make sure the user visible strings are translated

Translations are tough-to-impossible for custom themes though (unless I'm missing something)? Agreed in general and happy to work on it in the upcoming weeks (but after the CERN bucket list?)

I especially meant the themes we are shipping, if someone ships custom themes they can ship custom translations for theme names as well 😎

[pascalwengerter]

Closing in favor of #9698, thanks for the initiative and input!