fix: internally resolved public links triggering default action #9587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue where internally resolved public links instantly triggered the default file action. This behavior is not intended to work for public links, even if they resolve into an internal space.
|
Kudos, SonarCloud Quality Gate passed! |
fschade
approved these changes
Aug 23, 2023
AlexAndBear
approved these changes
Aug 23, 2023
delete-merged-branch
bot
deleted the
fix-public-link-resolving-to-internal
branch
ownclouders
pushed a commit
that referenced
this pull request
Aug 24, 2023
Fixes an issue where internally resolved public links instantly triggered the default file action. This behavior is not intended to work for public links, even if they resolve into an internal space.
ownclouders
pushed a commit
that referenced
this pull request
Aug 25, 2023
Fixes an issue where internally resolved public links instantly triggered the default file action. This behavior is not intended to work for public links, even if they resolve into an internal space.
ownclouders
pushed a commit
that referenced
this pull request
Aug 27, 2023
Fixes an issue where internally resolved public links instantly triggered the default file action. This behavior is not intended to work for public links, even if they resolve into an internal space.
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue where internally resolved public links instantly triggered the default file action. This behavior is not intended to work for public links if they resolve into an internal space.
Note
Only merge after
7.1.0has been released!Related Issue
Types of changes