Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: loading audio and video on Shared with me page #9595

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

JammingBen
Copy link
Collaborator

@JammingBen JammingBen commented Aug 18, 2023

Description

Fixes loading audio and video on the Shared with me page with the preview app. The problem was with a potential trailing slash in the download URL.

Note

Only merge after 7.1.0 has been released!

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Fixes loading audio and video on the Shared with me page with the preview app. The problem was with a potential trailing slash in the download URL.
@JammingBen JammingBen self-assigned this Aug 18, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

50.0% 50.0% Coverage
0.0% 0.0% Duplication

@AlexAndBear AlexAndBear marked this pull request as ready for review August 23, 2023 09:50
@AlexAndBear AlexAndBear merged commit c472d7c into stable-7.1 Aug 23, 2023
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix-view-audio-loading-shared-with-me branch August 23, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants