fix: duplicated file search request #9861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexAndBear
requested changes
Oct 25, 2023
| emit('search', buildSearchTerm(true)) | ||
| // return early if this view is not active, no search needed | ||
| { | ||
| const isSearchViewPainted = isLocationCommonActive(router, 'files-common-search') |
There was a problem hiding this comment.
yup, painted, e.g. painted on screen, rendered, visible, ...
There was a problem hiding this comment.
you like active better? but keep in mind, active can mean, active in background or similar and on screen
There was a problem hiding this comment.
"Mounted", as per Vue-jargon?
There was a problem hiding this comment.
i updated it to isSearchViewActive since the router guard is also called isLocationCommonActive, thanks guys for the input
fschade
force-pushed
the
fix-duplicated-search-request
branch
from
8620af5
to
4ce4a07
Compare
|
Kudos, SonarCloud Quality Gate passed! |
AlexAndBear
approved these changes
Oct 25, 2023
9 tasks
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes a bug where the search was sent unnecessarily twice.
Related Issue
How Has This Been Tested?
Types of changes
Checklist: