Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set first url input item active and highlight search results #9971

Merged
merged 2 commits into from
Nov 17, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions changelog/unreleased/enhancement-create-shortcuts
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ Users can enter URLs or pick a file via the drop down menu and create a '.url' f
https://github.com/owncloud/web/pull/9890
https://github.com/owncloud/web/pull/9908
https://github.com/owncloud/web/pull/9936
https://github.com/owncloud/web/pull/9971
https://github.com/owncloud/web/issues/9796
https://github.com/owncloud/web/issues/9887
https://github.com/owncloud/web/issues/9850
https://github.com/owncloud/web/issues/9963
https://github.com/owncloud/web/issues/9969
74 changes: 54 additions & 20 deletions packages/web-pkg/src/components/CreateShortcutModal.vue
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
>
<oc-list>
<li
class="oc-p-xs selectable-item"
class="oc-p-xs selectable-item selectable-item-url"
:class="{
active: isDropItemActive(0)
}"
Expand Down Expand Up @@ -96,12 +96,23 @@
</template>
<script lang="ts">
import { defineComponent, PropType, ref, unref, computed, nextTick, Ref } from 'vue'
import {
defineComponent,
PropType,
ref,
unref,
computed,
nextTick,
Ref,
watch,
onMounted
} from 'vue'
import { Resource, SpaceResource } from '@ownclouders/web-client'
import { useClientService, useFolderLink, useRouter, useSearch, useStore } from '../composables'
import { urlJoin } from '@ownclouders/web-client/src/utils'
import { useGettext } from 'vue3-gettext'
import DOMPurify from 'dompurify'
import Mark from 'mark.js'
import { OcDrop } from '@ownclouders/design-system/src/components'
import { resolveFileNameDuplicate } from '../helpers'
import { useTask } from 'vue-concurrency'
Expand Down Expand Up @@ -146,6 +157,7 @@ export default defineComponent({
const searchResult: Ref<SearchResult> = ref(null)
const activeDropItemIndex = ref(null)
const isDropOpen = ref(false)
let markInstance = null
const dropItemUrl = computed(() => {
let url = unref(inputUrl).trim()
Expand Down Expand Up @@ -252,29 +264,12 @@ export default defineComponent({
return index
}
const scrollToActiveDropItemIndex = () => {
if (typeof unref(dropRef).$el.scrollTo !== 'function') {
return
}
const elements = unref(dropRef).$el.querySelectorAll('.selectable-item')
unref(dropRef).$el.scrollTo(
0,
unref(activeDropItemIndex) === null
? 0
: elements[unref(activeDropItemIndex)].getBoundingClientRect().y -
elements[unref(activeDropItemIndex)].getBoundingClientRect().height
)
}
const onKeyUpDrop = () => {
activeDropItemIndex.value = findNextDropItemIndex(true)
scrollToActiveDropItemIndex()
}
const onKeyDownDrop = () => {
activeDropItemIndex.value = findNextDropItemIndex(false)
scrollToActiveDropItemIndex()
}
const onKeyEscDrop = (e: Event) => {
Expand Down Expand Up @@ -312,6 +307,7 @@ export default defineComponent({
const onShowDrop = () => {
isDropOpen.value = true
activeDropItemIndex.value = 0
}
const onClickUrlInput = () => {
Expand All @@ -335,7 +331,6 @@ export default defineComponent({
;(unref(dropRef) as InstanceType<typeof OcDrop>).show()
if (!isLocationPublicActive(router, 'files-public-link')) {
activeDropItemIndex.value = null
debouncedSearch()
}
}
Expand Down Expand Up @@ -367,6 +362,45 @@ export default defineComponent({
}
}
onMounted(async () => {
await nextTick()
markInstance = new Mark(unref(dropRef)?.$refs?.drop)
})
watch(
searchResult,
async () => {
await nextTick()
if (!unref(isDropOpen) || !markInstance) {
return
}
markInstance.unmark()
markInstance.mark(unref(inputUrl), {
element: 'span',
className: 'highlight-mark',
exclude: ['.selectable-item-url *', '.create-shortcut-modal-search-separator *']
})
},
{ deep: true }
)
watch(activeDropItemIndex, () => {
if (!unref(isDropOpen) || typeof unref(dropRef)?.$el?.scrollTo !== 'function') {
return
}
const elements = unref(dropRef).$el.querySelectorAll('.selectable-item')
unref(dropRef).$el.scrollTo(
0,
unref(activeDropItemIndex) === null
? 0
: elements[unref(activeDropItemIndex)].getBoundingClientRect().y -
elements[unref(activeDropItemIndex)].getBoundingClientRect().height
)
})
return {
inputUrl,
inputFilename,
Expand Down