Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rustdoc comments to all public APIs #130

Open
3 of 9 tasks
DonIsaac opened this issue Sep 19, 2024 · 2 comments
Open
3 of 9 tasks

Add rustdoc comments to all public APIs #130

DonIsaac opened this issue Sep 19, 2024 · 2 comments

Comments

@DonIsaac
Copy link

DonIsaac commented Sep 19, 2024

Good documentation is a critical part of promoting adoption from other projects. If users cannot understand how to use our tools, odds are they wont. We should document as much of our public API as possible. At the very least, all mostly-stable APIs should have examples and descriptions on how to use them.

We have a lot of great examples, but many options and return structures are missing descriptions. Plenty of business logic is also missing descriptions.

Crates

These are, in my opinion, the crates that are most important to document right now

Basically, if it's used anywhere from reading a file -> parsing -> transforming -> printing, then it is a high-priority candidate.

@DonIsaac DonIsaac added the good first issue Good for newcomers label Sep 19, 2024
Boshen referenced this issue in oxc-project/oxc Sep 19, 2024
@overlookmotel
Copy link

overlookmotel commented Sep 19, 2024

Just to add, documentation on internal APIs is also helpful - not just for new contributors, but also for the core team. I often find myself a bit lost in areas of codebase I've not been in for a while. Obviously, public API is higher priority, though.

Boshen referenced this issue in oxc-project/oxc Sep 25, 2024
@DonIsaac DonIsaac removed the good first issue Good for newcomers label Sep 26, 2024
DonIsaac referenced this issue in oxc-project/oxc Oct 4, 2024
- towards #5870

Adds some very basic docs for methods and properties related to `LintContext` and `ContextHost`.
camchenry referenced this issue in oxc-project/oxc Oct 4, 2024
- towards #5870

Adds some very basic docs for methods and properties related to `LintContext` and `ContextHost`.
camchenry referenced this issue in oxc-project/oxc Oct 4, 2024
- towards #5870

Adds some very basic docs for methods and properties related to `LintContext` and `ContextHost`.
@Boshen Boshen closed this as not planned Won't fix, can't repro, duplicate, stale Oct 14, 2024
@overlookmotel overlookmotel reopened this Oct 14, 2024
@overlookmotel
Copy link

I don't know why this won't transfer to backlog repo cleanly. Github seems to have some kinks.

But the main points of original issue are here. Original issue was oxc-project/oxc#5870

DonIsaac added a commit to oxc-project/oxc that referenced this issue Oct 15, 2024
Boshen pushed a commit to oxc-project/oxc that referenced this issue Oct 15, 2024
Boshen pushed a commit to oxc-project/oxc that referenced this issue Oct 15, 2024
…documentation (#6611)

Part of oxc-project/backlog#130

I didn't add doc comments to everything; I'm missing context for module-related data types and I have other things to do :P
Boshen pushed a commit to oxc-project/oxc that referenced this issue Oct 15, 2024
Boshen pushed a commit to oxc-project/oxc that referenced this issue Oct 15, 2024
DonIsaac added a commit to oxc-project/oxc that referenced this issue Oct 21, 2024
DonIsaac added a commit to oxc-project/oxc that referenced this issue Oct 21, 2024
Boshen pushed a commit to oxc-project/oxc that referenced this issue Oct 21, 2024
DonIsaac added a commit to oxc-project/oxc that referenced this issue Oct 21, 2024
Boshen pushed a commit to oxc-project/oxc that referenced this issue Oct 21, 2024
This issue is being transferred. Timeline may not be complete until it finishes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants