fix(semantic): generic passed to typeof not counted as a reference

oxc-project · Jul 27, 2024 · 2e5d03f · 2e5d03f
1 parent 40cafb8
commit 2e5d03f
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 2 deletions.
diff --git a/crates/oxc_semantic/src/builder.rs b/crates/oxc_semantic/src/builder.rs
@@ -1787,6 +1787,11 @@ impl<'a> SemanticBuilder<'a> {
                 //          ^^^^^^^^
                 self.current_reference_flag = ReferenceFlag::Read | ReferenceFlag::TSTypeQuery;
             }
+            AstKind::TSTypeParameterInstantiation(_) => {
+                // type A<T> = typeof a<T>;
+                //                     ^^^ avoid treat T as a value and TSTypeQuery
+                self.current_reference_flag -= ReferenceFlag::Read | ReferenceFlag::TSTypeQuery;
+            }
             AstKind::TSTypeName(_) => {
                 match self.nodes.parent_kind(self.current_node_id) {
                     Some(

diff --git a/..._semantic/tests/fixtures/typescript-eslint/instantiation-expressions/type-arguments2.snap b/..._semantic/tests/fixtures/typescript-eslint/instantiation-expressions/type-arguments2.snap
@@ -52,7 +52,14 @@ input_file: crates/oxc_semantic/tests/fixtures/typescript-eslint/instantiation-e
             "id": 4,
             "name": "T",
             "node": "TSTypeParameter",
-            "references": []
+            "references": [
+              {
+                "flag": "ReferenceFlag(Type)",
+                "id": 3,
+                "name": "T",
+                "node_id": 31
+              }
+            ]
           }
         ]
       }

diff --git a/...emantic/tests/fixtures/typescript-eslint/type-declaration/type-query-with-parameters.snap b/...emantic/tests/fixtures/typescript-eslint/type-declaration/type-query-with-parameters.snap
@@ -52,7 +52,14 @@ input_file: crates/oxc_semantic/tests/fixtures/typescript-eslint/type-declaratio
             "id": 4,
             "name": "T",
             "node": "TSTypeParameter",
-            "references": []
+            "references": [
+              {
+                "flag": "ReferenceFlag(Type)",
+                "id": 3,
+                "name": "T",
+                "node_id": 33
+              }
+            ]
           }
         ]
       }