fix(isolated_declarations): fix optional class methods

oxc-project · Jul 2, 2024 · 6edd31a · 6edd31a
1 parent 63c5f1e
commit 6edd31a
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 1 deletion.
diff --git a/crates/oxc_isolated_declarations/src/class.rs b/crates/oxc_isolated_declarations/src/class.rs
@@ -336,7 +336,9 @@ impl<'a> IsolatedDeclarations<'a> {
             match element {
                 ClassElement::StaticBlock(_) => {}
                 ClassElement::MethodDefinition(ref method) => {
-                    if !method.r#type.is_abstract() && method.value.body.is_none() {
+                    if !(method.r#type.is_abstract() || method.optional)
+                        && method.value.body.is_none()
+                    {
                         is_function_overloads = true;
                     } else if is_function_overloads {
                         // Skip implementation of function overloads

diff --git a/crates/oxc_isolated_declarations/tests/fixtures/class.ts b/crates/oxc_isolated_declarations/tests/fixtures/class.ts
@@ -14,6 +14,7 @@ export class Zoo {
 
 export abstract class Qux {
   abstract foo(): void;
+  protected foo2?(): void;
   bar(): void {}
   baz(): void {}
 }

diff --git a/crates/oxc_isolated_declarations/tests/snapshots/class.snap b/crates/oxc_isolated_declarations/tests/snapshots/class.snap
@@ -15,6 +15,7 @@ export declare class Zoo {
 }
 export declare abstract class Qux {
 	abstract foo(): void;
+	protected foo2?(): void;
 	bar(): void;
 	baz(): void;
 }