fix(transformer): remove an AstBuilder::copy call from TS namespace…

… transform (#4987) Replace an unsafe `AstBuilder::copy` call with `AstBuilder::move_expression` in TS namespace transform.
oxc-project · Aug 19, 2024 · 6ffbd78 · 6ffbd78
1 parent a8dfdda
commit 6ffbd78
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/crates/oxc_transformer/src/typescript/namespace.rs b/crates/oxc_transformer/src/typescript/namespace.rs
@@ -460,7 +460,7 @@ impl<'a> TypeScript<'a> {
                 let Some(property_name) = declarator.id.get_identifier() else {
                     return;
                 };
-                if let Some(init) = &declarator.init {
+                if let Some(init) = &mut declarator.init {
                     declarator.init = Some(
                         self.ctx.ast.expression_assignment(
                             SPAN,
@@ -476,8 +476,7 @@ impl<'a> TypeScript<'a> {
                                     ),
                                 )
                                 .into(),
-                            // SAFETY: `ast.copy` is unsound! We need to fix.
-                            unsafe { self.ctx.ast.copy(init) },
+                            self.ctx.ast.move_expression(init),
                         ),
                     );
                 }