perf(linter/react): add should_run conditions for react rules (#5402)

oxc-project · Sep 4, 2024 · 8170954 · 8170954
1 parent f89c776
commit 8170954
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/crates/oxc_linter/src/rules/react/jsx_boolean_value.rs b/crates/oxc_linter/src/rules/react/jsx_boolean_value.rs
@@ -147,6 +147,10 @@ impl Rule for JsxBooleanValue {
             }
         }
     }
+
+    fn should_run(&self, ctx: &LintContext) -> bool {
+        ctx.source_type().is_jsx()
+    }
 }
 
 impl JsxBooleanValue {

diff --git a/crates/oxc_linter/src/rules/react/jsx_props_no_spread_multi.rs b/crates/oxc_linter/src/rules/react/jsx_props_no_spread_multi.rs
@@ -120,6 +120,10 @@ impl Rule for JsxPropsNoSpreadMulti {
             );
         }
     }
+
+    fn should_run(&self, ctx: &LintContext) -> bool {
+        ctx.source_type().is_jsx()
+    }
 }
 
 #[test]
-Original file line number
+Diff line change
@@ Expand Up / @@ -147,6 +147,10 @@ impl Rule for JsxBooleanValue { @@
                 }
             }
         }
+        fn should_run(&self, ctx: &LintContext) -> bool {
+            ctx.source_type().is_jsx()
+        }
     }
     impl JsxBooleanValue {
@@ Expand Down @@