-
-
Notifications
You must be signed in to change notification settings - Fork 482
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
test(semantic): add a test for catch parameters reference (#7988)
I am trying to clean up Semantic, just found that we can remove this code without any test failing, but it should fail in that test case I added. https://github.com/oxc-project/oxc/blob/1082868855ba67b03a5bd03211f1b23262976410/crates/oxc_semantic/src/builder.rs#L2085-L2087
- Loading branch information
Showing
2 changed files
with
96 additions
and
0 deletions.
There are no files selected for viewing
9 changes: 9 additions & 0 deletions
9
crates/oxc_semantic/tests/fixtures/oxc/js/try-catch/parameters.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| let a = 0, A = 0; | ||
| try { } catch ( | ||
| { a = A, | ||
| // ^ is referenced to parent scope's `A` | ||
| b = a } | ||
| // ^ is referenced to parameter `a` | ||
| ) { | ||
| let A = 0 ; | ||
| } |
87 changes: 87 additions & 0 deletions
87
crates/oxc_semantic/tests/fixtures/oxc/js/try-catch/parameters.snap
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,87 @@ | ||
| --- | ||
| source: crates/oxc_semantic/tests/main.rs | ||
| input_file: crates/oxc_semantic/tests/fixtures/oxc/js/try-catch/parameters.js | ||
| --- | ||
| [ | ||
| { | ||
| "children": [ | ||
| { | ||
| "children": [], | ||
| "flags": "ScopeFlags(StrictMode)", | ||
| "id": 1, | ||
| "node": "BlockStatement", | ||
| "symbols": [] | ||
| }, | ||
| { | ||
| "children": [ | ||
| { | ||
| "children": [], | ||
| "flags": "ScopeFlags(StrictMode)", | ||
| "id": 3, | ||
| "node": "BlockStatement", | ||
| "symbols": [ | ||
| { | ||
| "flags": "SymbolFlags(BlockScopedVariable | CatchVariable)", | ||
| "id": 2, | ||
| "name": "a", | ||
| "node": "CatchParameter", | ||
| "references": [ | ||
| { | ||
| "flags": "ReferenceFlags(Read)", | ||
| "id": 1, | ||
| "name": "a", | ||
| "node_id": 22 | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "flags": "SymbolFlags(BlockScopedVariable | CatchVariable)", | ||
| "id": 3, | ||
| "name": "b", | ||
| "node": "CatchParameter", | ||
| "references": [] | ||
| }, | ||
| { | ||
| "flags": "SymbolFlags(BlockScopedVariable)", | ||
| "id": 4, | ||
| "name": "A", | ||
| "node": "VariableDeclarator(A)", | ||
| "references": [] | ||
| } | ||
| ] | ||
| } | ||
| ], | ||
| "flags": "ScopeFlags(StrictMode | CatchClause)", | ||
| "id": 2, | ||
| "node": "CatchClause", | ||
| "symbols": [] | ||
| } | ||
| ], | ||
| "flags": "ScopeFlags(StrictMode | Top)", | ||
| "id": 0, | ||
| "node": "Program", | ||
| "symbols": [ | ||
| { | ||
| "flags": "SymbolFlags(BlockScopedVariable)", | ||
| "id": 0, | ||
| "name": "a", | ||
| "node": "VariableDeclarator(a)", | ||
| "references": [] | ||
| }, | ||
| { | ||
| "flags": "SymbolFlags(BlockScopedVariable)", | ||
| "id": 1, | ||
| "name": "A", | ||
| "node": "VariableDeclarator(A)", | ||
| "references": [ | ||
| { | ||
| "flags": "ReferenceFlags(Read)", | ||
| "id": 0, | ||
| "name": "A", | ||
| "node_id": 17 | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| ] |