Skip to content

Commit

Permalink
refactor(linter): use std::ptr::eq (#5649)
Browse files Browse the repository at this point in the history
Follow-on after #5577.

`!std::ptr::eq(x, y)` is more idiomatic than `std::ptr::from_ref(x) != std::ptr::from_ref(y)`.
  • Loading branch information
overlookmotel committed Sep 9, 2024
1 parent 19cdcc5 commit c8bc6f0
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ impl Rule for NoUselessSwitchCase {
let default_case = default_cases[0];

// Check if the `default` case is the last case
if std::ptr::from_ref(default_case) != std::ptr::from_ref(cases.last().unwrap()) {
if !std::ptr::eq(default_case, cases.last().unwrap()) {
return;
}

Expand Down
2 changes: 1 addition & 1 deletion crates/oxc_linter/src/rules/unicorn/prefer_event_target.rs
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ impl Rule for PreferEventTarget {
return;
};

if std::ptr::from_ref(ident) != std::ptr::addr_of!(**callee_ident) {
if !std::ptr::eq(ident, callee_ident.as_ref()) {
return;
}
}
Expand Down
4 changes: 2 additions & 2 deletions crates/oxc_linter/src/rules/unicorn/prefer_regexp_test.rs
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ impl Rule for PreferRegexpTest {
};

// Check if the `test` of the for statement is the same node as the call expression.
if std::ptr::addr_of!(**call_expr2) != std::ptr::from_ref(call_expr) {
if !std::ptr::eq(call_expr2.as_ref(), call_expr) {
return;
}
}
Expand All @@ -97,7 +97,7 @@ impl Rule for PreferRegexpTest {
};

// Check if the `test` of the conditional expression is the same node as the call expression.
if std::ptr::addr_of!(**call_expr2) != std::ptr::from_ref(call_expr) {
if !std::ptr::eq(call_expr2.as_ref(), call_expr) {
return;
}
}
Expand Down

0 comments on commit c8bc6f0

Please sign in to comment.