fix(codegen): fix whitespace issue when minifying x in new Error() (#…

…4886)
oxc-project · Aug 14, 2024 · e8de4bd · e8de4bd
1 parent c164bb8
commit e8de4bd
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/crates/oxc_codegen/src/gen.rs b/crates/oxc_codegen/src/gen.rs
@@ -2101,6 +2101,7 @@ impl<'a, const MINIFY: bool> GenExpr<MINIFY> for NewExpression<'a> {
             if let Some(comment) = annotate_comment {
                 p.print_comment(comment);
             }
+            p.print_space_before_identifier();
             p.add_source_mapping(self.span.start);
             p.print_str("new ");
             self.callee.gen_expr(p, Precedence::New, Context::FORBID_CALL);

diff --git a/crates/oxc_codegen/tests/integration/unit.rs b/crates/oxc_codegen/tests/integration/unit.rs
@@ -17,6 +17,7 @@ fn expr() {
         }",
         "class Foo {\n\t#test;\n\tbar() {\n\t\tif (!(#test in Foo)) {}\n\t}\n}\n",
     );
+    test_minify("x in new Error()", "x in new Error();");
 }
 
 #[test]
-Original file line number
+Diff line change
@@ Expand Up / @@ -17,6 +17,7 @@ fn expr() { @@
             }",
             "class Foo {\n\t#test;\n\tbar() {\n\t\tif (!(#test in Foo)) {}\n\t}\n}\n",
         );
+        test_minify("x in new Error()", "x in new Error();");
     }
     #[test]
@@ Expand Down @@