You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
test262 only ensure the all indentifier are resolved, doesn't ensure correctness.
Manual testing ensure correctness but only have a few cases.
Problems
With the above summary, the current scope analysis is running in half dark.
Can't not detect effects/changes. If someone changes scope analysis code, we could only rely on the few manual tests to ensure the correctness.
Dx of writing Manual tests is bad. The API could handle simple cases well. But we have to admit that, as much as we want to try make the test case simple, there's a bigger chance we need to handle complicated code. Writing manual tests for them seems impossible with current test API.
Solutions
We assume the current scope analysis behaviors are correct and visualize them in snapshot testing.
Visualize scope information of tests262 and also manual tests.
If someone change scope analysis code, we could review if it is correct by review changes of snapshot.
The text was updated successfully, but these errors were encountered:
This issue is follow-up of #1227 and #2498.
Status quo
oxc currently rely on test262 and manual testing.
test262:
https://github.com/oxc-project/oxc/blob/1519b9000bcdc7c43c79c8b26e194a13f7df1f1e/crates/oxc_semantic/tests/scopes.rs
manual testing:
oxc/tasks/coverage/src/test262.rs
Lines 212 to 235 in e2d2ce3
Problems
With the above summary, the current scope analysis is running in half dark.
Solutions
If someone change scope analysis code, we could review if it is correct by review changes of snapshot.
The text was updated successfully, but these errors were encountered: