Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linter: no-unreachable false positives in the vscode repo #3663

Closed
Boshen opened this issue Jun 14, 2024 · 1 comment · Fixed by #3667 or #3672
Closed

linter: no-unreachable false positives in the vscode repo #3663

Boshen opened this issue Jun 14, 2024 · 1 comment · Fixed by #3667 or #3672
Assignees
@rzvxa
Labels
A-linter Area - Linter C-bug Category - Bug

Comments

@Boshen
Copy link
Member

Boshen commented Jun 14, 2024

CI: https://github.com/oxc-project/oxlint-ecosystem-ci/actions/runs/9510979886/job/26216443988

I moved the rule to nursery in ce6cacc so no rush 😁
@Boshen Boshen added C-bug Category - Bug A-linter Area - Linter labels Jun 14, 2024
@rzvxa
Copy link
Contributor

rzvxa commented Jun 14, 2024

I'll take care of it

@rzvxa rzvxa mentioned this issue Jun 14, 2024
Merged
Boshen pushed a commit that referenced this issue Jun 14, 2024
@rzvxa
fix(semantic/cfg): correct unreachability propagation in try-finally. (…
e148a32 
…#3667)

closes #3663


[oxlint-ecosystem-ci](https://github.com/rzvxa/oxlint-ecosystem-ci/actions/runs/9511509383/job/26217870705)

From this:

![Screenshot 2024-06-14
092916](https://github.com/oxc-project/oxc/assets/3788964/9e6a9a01-984a-4a19-8a73-abc3b71fb9c2)

To this:

![Screenshot 2024-06-14
092852](https://github.com/oxc-project/oxc/assets/3788964/46483bc2-a227-4416-b8da-07b11ab96990)

Since try-finally (without a catch) wouldn't join after finalization.
@rzvxa rzvxa mentioned this issue Jun 14, 2024
Merged
@rzvxa rzvxa reopened this Jun 14, 2024
Boshen pushed a commit that referenced this issue Jun 14, 2024
@rzvxa
fix(linter): edge case with infinite loops. (#3672)
cf71c23 
closes #3663 this time for real😅

browser search doesn't work in the GitHub actions (because of the partial rendering I guess) I had to use GitHub's own log search to see all instances related to this rule.

[oxlint-ecosystem-ci](https://github.com/rzvxa/oxlint-ecosystem-ci/actions/runs/9512820948)
@rzvxa rzvxa closed this as completed Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rzvxa rzvxa

Labels
A-linter Area - Linter C-bug Category - Bug
Projects
None yet
Milestone
No milestone
2 participants
@Boshen @rzvxa