You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
test('extension is not outdated when there is no local and gallery', () => {
const extension = instantiationService.createInstance(Extension, () => ExtensionState.Installed, () => undefined, undefined, undefined, undefined, undefined);
assert.strictEqual(extension.outdated, false);
});
I found that span is an interval that is closed on the left and open on the right. It should not be <=, which will cause the continuous interval to be skipped. It should be <.
The test case has to be modified to allow continuous interval modification, but I found that it will cause no_useless_escape test failure
microsoft/vscode@c37f4a4/src/vs/workbench/contrib/extensions/test/electron-sandbox/extension.test.ts#L29-L32
Our fixer needs to run twice to fix this, tested on unicorn/no-useless-undefined, it needs once.
Why our fixer need to run twice
https://github.com/oxc-project/oxc/blob/main/crates/oxc_linter/src/fixer.rs#L278
I found that
span
is an interval that is closed on the left and open on the right. It should not be<=
, which will cause the continuous interval to be skipped. It should be<
.The test case has to be modified to allow continuous interval modification, but I found that it will cause
no_useless_escape
test failurehttps://github.com/oxc-project/oxc/blob/main/crates/oxc_linter/src/fixer.rs#L520
Originally posted by @cblh in #4079 (comment)
The text was updated successfully, but these errors were encountered: