parser: add regex AST node

[Boshen]

oxc/crates/oxc_parser/src/js/expression.rs

Lines 348 to 351 in afe728a

	let _pattern = self
	.options
	.parse_regular_expression
	.then(|| self.parse_regex_pattern(pattern_start, pattern, flags));

This pattern node cannot be added to the AST due to not having CloneIn implemented. cc @rzvxa

[rzvxa]

@Boshen Do we want these types to be feature-gated? If so It seems this would take more time than I initially expected. It requires me to go in and refactor stuff related to our AST layout to support conditional layouts.
It would also mean that we have to distinguish between these layouts when doing AST transfer but it isn't too hard to support, It just takes more time as we need to represent conditional fields and type definitions.

[Boshen]

@Boshen Do we want these types to be feature-gated? If so It seems this would take more time than I initially expected. It requires me to go in and refactor stuff related to our AST layout to support conditional layouts. It would also mean that we have to distinguish between these layouts when doing AST transfer but it isn't too hard to support, It just takes more time as we need to represent conditional fields and type definitions.

Welcome back ❤️

No feature gate is needed, all the regular expression parsing code is really lightweight.

[rzvxa]

Welcome back ❤️

Thanks Captain!⚓

No feature gate is needed, all the regular expression parsing code is really lightweight.

That's great to hear, It Simplifies the process and doesn't prevent us from adding it later on as a follow-up PR.
If you would like to feature-gate it in the future, Let me know so I can create an issue for it in the backlog.

[rzvxa]

Should we close this issue?

[rzvxa]

I'll close it since #5256 addresses this. Feel free to reopen if you think the requirements for this issue aren't met yet.