Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(semantic): implicit return in arrow function does not count as a read #5156

Closed
DonIsaac opened this issue Aug 23, 2024 · 1 comment · Fixed by #5161
Closed

bug(semantic): implicit return in arrow function does not count as a read #5156

DonIsaac opened this issue Aug 23, 2024 · 1 comment · Fixed by #5161
Assignees
@DonIsaac
Labels
A-semantic Area - Semantic C-bug Category - Bug

Comments

@DonIsaac
Copy link
Contributor

DonIsaac commented Aug 23, 2024 •
edited
Loading

Given a variable i:

Expected behavior
image

Actual behavior
image

This causes no-unused-vars to incorrectly report i as unused.
@DonIsaac DonIsaac added C-bug Category - Bug A-semantic Area - Semantic labels Aug 23, 2024
@DonIsaac DonIsaac mentioned this issue Aug 23, 2024
Closed
@DonIsaac DonIsaac assigned DonIsaac and unassigned Dunqing Aug 23, 2024
@DonIsaac DonIsaac linked a pull request Aug 23, 2024 that will close this issue
fix(semantic): consider update expressions in implicit returns as reads #5158
Closed
@Boshen
Copy link
Member

Boshen commented Aug 24, 2024

I recall @Dunqing made some changes to update expression before.

@Dunqing Dunqing mentioned this issue Aug 24, 2024
Merged
DonIsaac pushed a commit that referenced this issue Aug 26, 2024
@Dunqing
fix(semantic): implicit return UpdateExpression in `ArrowFunctionEx…
293413f 
…pression` does not as read reference (#5161)

close: #5158
close: #5156
@Dunqing Dunqing closed this as completed Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DonIsaac DonIsaac

Labels
A-semantic Area - Semantic C-bug Category - Bug
Projects
None yet
Milestone
No milestone
3 participants
@Boshen @DonIsaac @Dunqing