Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minifier: handle parens in dce #5436

Closed
Boshen opened this issue Sep 4, 2024 · 2 comments
Closed

minifier: handle parens in dce #5436

Boshen opened this issue Sep 4, 2024 · 2 comments
Assignees
@Boshen
Labels
C-bug Category - Bug

Comments

@Boshen
Copy link
Member

Boshen commented Sep 4, 2024

See rolldown/rolldown#2153
@Boshen Boshen added the C-bug Category - Bug label Sep 4, 2024
@Boshen Boshen self-assigned this Sep 4, 2024
@Boshen
Copy link
Member Author

Boshen commented Sep 4, 2024

Note: need to revert this change in crates/rolldown/src/utils/pre_process_ecma_ast.rs

let options = CompressOptions {
      fold_constants: true,
      remove_dead_code: true,
      remove_syntax: true,

Boshen added a commit that referenced this issue Sep 4, 2024
@Boshen
feat(minifier): remove parenthesized expression for dce
993220a 
relates #5436
@Boshen Boshen mentioned this issue Sep 4, 2024
Merged
Boshen added a commit that referenced this issue Sep 4, 2024
@Boshen
feat(minifier): remove parenthesized expression for dce (#5439)
ba4b68c 
relates #5436
@DonIsaac
Copy link
Contributor

DonIsaac commented Sep 5, 2024

@Boshen did #5439 resolve this ticket?

@Boshen Boshen closed this as completed Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Boshen Boshen

Labels
C-bug Category - Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Boshen @DonIsaac