Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

codegen: no need to print trailing_comma for ArrayExpression #5532

Closed
Dunqing opened this issue Sep 6, 2024 · 1 comment · Fixed by #5551
Closed

codegen: no need to print trailing_comma for ArrayExpression #5532

Dunqing opened this issue Sep 6, 2024 · 1 comment · Fixed by #5551
Assignees
@Boshen
Labels
C-enhancement Category - New feature or request

Comments

@Dunqing
Copy link
Member

Dunqing commented Sep 6, 2024

https://playground.oxc.rs/#eNo9jUEOwyAMBL8S7ZlLe+QrVQ+UmgoJcGQTqVHE3wOKyMkztrV7wMPi9TDL0yxvGDDsAdnKGLqX6v6wVTYySLHUyep5pVv2/OE0rYorGlgybHBJqRmsTpSkJ3YeKZPv17nw/KUfje4uOZYY4nVq7QRM5zno
@Dunqing Dunqing added the C-enhancement Category - New feature or request label Sep 6, 2024
Boshen added a commit that referenced this issue Sep 6, 2024
@Boshen
fix(codegen): do not print trailing commas
eeb8c52 
closes #5532
@Boshen Boshen mentioned this issue Sep 6, 2024
Merged
Boshen added a commit that referenced this issue Sep 6, 2024
@Boshen
fix(codegen): do not print trailing commas
abfe897 
closes #5532
Boshen added a commit that referenced this issue Sep 6, 2024
@Boshen
fix(codegen): do not print trailing commas for ArrayExpression (#5551)
d62defb 
closes #5532
@camc314
Copy link
Contributor

camc314 commented Sep 6, 2024

Fixed by #5551

@camc314 camc314 closed this as completed Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Boshen Boshen

Labels
C-enhancement Category - New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(codegen): do not print trailing commas for ArrayExpression oxc-project/oxc
3 participants
@Boshen @camc314 @Dunqing