Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linter: oxc for vscode, document.createElement("iframe") - missing a sandbox attribute #6750

Closed
lborgman opened this issue Oct 21, 2024 · 0 comments · Fixed by #6872
Closed

linter: oxc for vscode, document.createElement("iframe") - missing a sandbox attribute #6750

lborgman opened this issue Oct 21, 2024 · 0 comments · Fixed by #6872
Assignees
@DonIsaac
Labels
A-linter Area - Linter C-bug Category - Bug

Comments

@lborgman
Copy link

What version of Oxlint are you using?

0.10.1

What command did you run?

oxc vscode extension

What does your .oxlint.json config file look like?

As far as I know there is no .oxlint.json

What happened?

I have this line in a .js file:

const i = document.createElement("iframe");

I get this from oxc:

An iframe element is missing a sandbox attribute
help: Add a sandbox attribute to the iframe element.oxc[eslint-plugin-react(iframe-missing-sandbox)]>
(https://oxc.rs/docs/guide/usage/linter/rules/eslint-plugin-react/iframe-missing-sandbox)

I am not using React. And I have no idea about the plugin mentioned. (And the link above gives 404.)
@lborgman lborgman added A-linter Area - Linter C-bug Category - Bug labels Oct 21, 2024
This was referenced Oct 22, 2024
Merged
Closed
@DonIsaac DonIsaac mentioned this issue Oct 24, 2024
Merged
Boshen pushed a commit that referenced this issue Oct 25, 2024
@DonIsaac
fix(linter): react/iframe-missing-sandbox ignores vanilla JS APIs (#…
f49b3e2 
…6872)

> Closes #6750

Fixes a false positive in `react/iframe-missing-sandbox` on `document.createElement`, which is not react and has no way of passing a sandbox prop/attribute on creation.
Orenbek pushed a commit to Orenbek/oxc that referenced this issue Oct 28, 2024
@DonIsaac @Orenbek
fix(linter): react/iframe-missing-sandbox ignores vanilla JS APIs (o…
ebdb3ff 
…xc-project#6872)

> Closes oxc-project#6750

Fixes a false positive in `react/iframe-missing-sandbox` on `document.createElement`, which is not react and has no way of passing a sandbox prop/attribute on creation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DonIsaac DonIsaac

Labels
A-linter Area - Linter C-bug Category - Bug
Projects
None yet
Milestone
No milestone
2 participants
@lborgman @DonIsaac