Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release new @oxc-project/types NPM package #6862

Closed
overlookmotel opened this issue Oct 24, 2024 · 3 comments · Fixed by #6874
Closed

Release new @oxc-project/types NPM package #6862

overlookmotel opened this issue Oct 24, 2024 · 3 comments · Fixed by #6874
Assignees
@Boshen
Labels
C-bug Category - Bug

Comments

@overlookmotel
Copy link
Contributor

overlookmotel commented Oct 24, 2024 •
edited
Loading

#6755 and #6796 introduced a new NPM package @oxc/types. But we don't control the @oxc NPM scope. We need to decide a name for this package. oxc-types? @oxc-project/types?

Also, those PRs altered the publish workflows, and I'm not sure if this was all reviewed or not before merging.

We should not make a release until this is resolved. Releasing from current state of repo would break oxc-parser and @oxc-parser/wasm NPM packages.
@overlookmotel overlookmotel added the C-bug Category - Bug label Oct 24, 2024
@Boshen
Copy link
Member

Boshen commented Oct 24, 2024

@oxc-project/types

@ottomated ottomated mentioned this issue Oct 24, 2024
Merged
@overlookmotel
Copy link
Contributor Author

#6874 changed the package name to @oxc-project/types.

@Boshen is there anything else we need to do to make package release work, or are we all set to release these types onto the world?

overlookmotel pushed a commit that referenced this issue Oct 24, 2024
@ottomated
fix(types): Change @oxc/types package name (#6874)
b075982 
Closes #6862.

Possible options:
- `oxc-types`
- `@oxc-project/types`
- `@oxc-ast/types`
- `oxc-ast-types`
@ottomated
Copy link
Contributor

Looks like the release CI needs to be kickstarted by a manual release with how the version check works.

@overlookmotel overlookmotel mentioned this issue Oct 25, 2024
Open
@overlookmotel overlookmotel changed the title Fix NPM package name for AST types Release new @oxc-project/types NPM package Oct 25, 2024
@Boshen Boshen closed this as completed Oct 26, 2024
Orenbek pushed a commit to Orenbek/oxc that referenced this issue Oct 28, 2024
@ottomated @Orenbek
fix(types): Change @oxc/types package name (oxc-project#6874)
c59c9cc 
Closes oxc-project#6862.

Possible options:
- `oxc-types`
- `@oxc-project/types`
- `@oxc-ast/types`
- `oxc-ast-types`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Boshen Boshen

Labels
C-bug Category - Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(types): Change @oxc/types package name oxc-project/oxc
3 participants
@overlookmotel @Boshen @ottomated