Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linter): eslint-plugin-jsx-a11y scope rule (correctness) #1609

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

Shinyaigeek
Copy link
Contributor

Summary

partof: #1141

I re-implemented scope rule for jsx_a11y in Rust same as the original JS one, and moved also the test related to the rule to here.

originals:

@github-actions github-actions bot added the A-linter Area - Linter label Dec 2, 2023
@Boshen
Copy link
Member

Boshen commented Dec 4, 2023

I think the rust alternatives aria-query is useful for development of oxc-builtin another linter plugin, and also will be useful for the future linter plugin system.

After looking at aria-query, we can setup an individual repo inside the oxc-project org and develop it outside of oxc. I can invite you to the org if you are up to the challenge of developing and maintaining it ;-)

@Shinyaigeek
Copy link
Contributor Author

Shinyaigeek commented Dec 4, 2023

After looking at aria-query, we can setup an individual repo inside the oxc-project org and develop it outside of oxc. I can invite you to the org if you are up to the challenge of developing and maintaining it ;-)

@Boshen OK I see, I am eager to challenge it 👍 If you invite me to the org, I will be really pleasure and will become able to make a progress in rust alternative aria-query🙇

@Boshen
Copy link
Member

Boshen commented Dec 4, 2023

After looking at aria-query, we can setup an individual repo inside the oxc-project org and develop it outside of oxc. I can invite you to the org if you are up to the challenge of developing and maintaining it ;-)

@Boshen OK I see, I am eager to challenge it 👍 If you invite me to the org, I will be really pleasure and will become able to make a progress in rust alternative aria-query🙇

https://github.com/oxc-project/aria-query/invitations

Can you also do a quick rebase on this PR so I can merge it.

@Shinyaigeek Shinyaigeek force-pushed the implement-jsx-a11y-scope branch from f8623cd to cea3580 Compare December 5, 2023 17:22
@Shinyaigeek
Copy link
Contributor Author

@Boshen sorry for late response. I did it! 👍

@Boshen Boshen merged commit ddb3c62 into oxc-project:main Dec 6, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants