New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(linter): jsx-no-undef for eslint-plugin-react #1862

Merged

camc314 merged 4 commits into oxc-project:main from XantreDev:react_jsx_no_undef

Dec 31, 2023

Contributor

XantreDev commented Dec 31, 2023 •

edited

Loading

github-actions bot added the A-linter label

XantreDev changed the title ~~React jsx no undef~~ feat(linter): jsx-no-undef for eslint-plugin-react

XantreDev marked this pull request as ready for review

December 31, 2023 11:42

XantreDev added 3 commits

December 31, 2023 12:48


          initial implementation of react_jsx_no_undef

584a9bc


          added plugin descripton and updated snapshot

682606b


          fix: handled this case

402cd2d

camc314 reviewed

View reviewed changes

crates/oxc_linter/src/rules/react/jsx_no_undef.rs Outdated Show resolved Hide resolved

XantreDev force-pushed the react_jsx_no_undef branch from efc1de4 to 402cd2d Compare

December 31, 2023 11:48

camc314 reviewed

View reviewed changes

Contributor

camc314 left a comment

Looking great!


          removed unnecessary regex

65b9f0f

camc314 approved these changes

View reviewed changes

Contributor

camc314 left a comment

Thank you!

camc314 enabled auto-merge (squash)

December 31, 2023 11:55

camc314 merged commit ba0a4a8 into oxc-project:main

15 checks passed

Contributor Author

XantreDev commented Dec 31, 2023 •

edited

Loading

Thank you for review. It's my first Rust contribution)

Contributor

camc314 commented Dec 31, 2023

Thank you for review. It's my first Rust contribution)

Thank you for contributing!

Brooooooklyn referenced this pull request in toeverything/AFFiNE


          chore: bump up oxlint version to v0.1.2 (#5528)

e5db566

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [oxlint](https://oxc-project.github.io) ([source](https://github.com/oxc-project/oxc/tree/HEAD/npm/oxlint)) | [`0.0.22` -> `0.1.2`](https://renovatebot.com/diffs/npm/oxlint/0.0.22/0.1.2) | [![age](https://developer.mend.io/api/mc/badges/age/npm/oxlint/0.1.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/oxlint/0.1.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/oxlint/0.0.22/0.1.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/oxlint/0.0.22/0.1.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>oxc-project/oxc (oxlint)</summary>

### [`v0.1.2`](https://github.com/oxc-project/oxc/releases/tag/oxlint_v0.1.2): oxlint v0.1.2

[Compare Source](https://github.com/oxc-project/oxc/compare/821cc8e9c7cfb326ff546483bb2a32d12e018e4c...4a9e0c4bf4179bf5839b690be3690163ff00e2ef)

#### Try it out!

-   Run `npx --yes oxlint@latest` from your terminal
-   Install the Vscode extension https://marketplace.visualstudio.com/items?itemName=oxc.oxc-vscode
-   Read the [usage guide](https://oxc-project.github.io/docs/guide/usage/linter.html)

#### Svelte support

`<script>` tag is linted by default.

#### Features

-   feat(linter): <script> part of svelte file by [@&#8203;Boshen](https://github.com/Boshen) in [https://github.com/oxc-project/oxc/pull/1918](https://github.com/oxc-project/oxc/pull/1918)
-   feat(linter): disable no-unused-labels for svelte by [@&#8203;Boshen](https://github.com/Boshen) in [https://github.com/oxc-project/oxc/pull/1919](https://github.com/oxc-project/oxc/pull/1919)

### Fixes

-   fix(linter): change no-var to restriction [`bb6128b`](https://github.com/oxc-project/oxc/commit/bb6128b)
-   chore: add some useful informantion log by [@&#8203;IWANABETHATGUY](https://github.com/IWANABETHATGUY) in [https://github.com/oxc-project/oxc/pull/1912](https://github.com/oxc-project/oxc/pull/1912)
-   fix(linter) fix eslint config for filename case by [@&#8203;camc314](https://github.com/camc314) in [https://github.com/oxc-project/oxc/pull/1913](https://github.com/oxc-project/oxc/pull/1913)

**Full Changelog**: oxc-project/oxc@oxlint_v0.1.1...oxlint_v0.1.2

### [`v0.1.1`](https://github.com/oxc-project/oxc/releases/tag/oxlint_v0.1.1): oxlint v0.1.1

[Compare Source](https://github.com/oxc-project/oxc/compare/v0.1.0...821cc8e9c7cfb326ff546483bb2a32d12e018e4c)

#### Try it out!

-   Run `npx --yes oxlint@latest` from your terminal
-   Install the Vscode extension https://marketplace.visualstudio.com/items?itemName=oxc.oxc-vscode
-   Read the [usage guide](https://oxc-project.github.io/docs/guide/usage/linter.html)

#### Vue support

`<script>` and `<script setup>` are linted by default.

#### Astro support

Frontmatter component script `---` and all `<script>` tags are linted by default.

#### Configuration files (experimental)

`-c ./eslintrc.json` will use the `rules` field for rule configuration, as documented in [ESLint's documentation](https://eslint.org/docs/latest/use/configure/rules#using-configuration-files).

Unfortunately, only the `json` format is supported right now.

The `extends` field will not take effect; normal `-D` and `-A` flags still apply.

#### New Rules

##### Correctness

-   deepscan: bad object literal comparison by [@&#8203;camc314](https://github.com/camc314) in [https://github.com/oxc-project/oxc/pull/1844](https://github.com/oxc-project/oxc/pull/1844)
-   oxc: erasing op by [@&#8203;camc314](https://github.com/camc314) in [https://github.com/oxc-project/oxc/pull/1834](https://github.com/oxc-project/oxc/pull/1834)
-   oxc: only used in recursion by [@&#8203;camc314](https://github.com/camc314) in [https://github.com/oxc-project/oxc/pull/1833](https://github.com/oxc-project/oxc/pull/1833)
-   eslint: no irregular whitespace by [@&#8203;DeividAlmeida](https://github.com/DeividAlmeida) in [https://github.com/oxc-project/oxc/pull/1877](https://github.com/oxc-project/oxc/pull/1877)
-   eslint: no-unused-private-class-members rule by [@&#8203;Dunqing](https://github.com/Dunqing) in [https://github.com/oxc-project/oxc/pull/1820](https://github.com/oxc-project/oxc/pull/1820)
-   eslint: no-var by [@&#8203;zhangrunzhao](https://github.com/zhangrunzhao) in [https://github.com/oxc-project/oxc/pull/1890](https://github.com/oxc-project/oxc/pull/1890)
-   eslint-plugin-react: jsx-no-undef for by [@&#8203;XantreGodlike](https://github.com/XantreGodlike) in [https://github.com/oxc-project/oxc/pull/1862](https://github.com/oxc-project/oxc/pull/1862)
-   eslint-plugin-jsx-a11y: aria-role by [@&#8203;msdlisper](https://github.com/msdlisper) in [https://github.com/oxc-project/oxc/pull/1849](https://github.com/oxc-project/oxc/pull/1849)
-   eslint-plugin-jsx-a11y: lang by [@&#8203;msdlisper](https://github.com/msdlisper) in [https://github.com/oxc-project/oxc/pull/1812](https://github.com/oxc-project/oxc/pull/1812)
-   eslint-plugin-jsx-a11y: media-has-caption by [@&#8203;poteboy](https://github.com/poteboy) in [https://github.com/oxc-project/oxc/pull/1822](https://github.com/oxc-project/oxc/pull/1822)
-   eslint-plugin-jsx-a11y: mouse-events-have-key-events(correctness) by [@&#8203;Ken-HH24](https://github.com/Ken-HH24) in [https://github.com/oxc-project/oxc/pull/1867](https://github.com/oxc-project/oxc/pull/1867)
-   eslint-plugin-jsx-a11y: prefer-tag-over-role rule by [@&#8203;yossydev](https://github.com/yossydev) in [https://github.com/oxc-project/oxc/pull/1831](https://github.com/oxc-project/oxc/pull/1831)
-   eslint-plugin-jsx-a11y: aria-unsupported-elements by [@&#8203;re-taro](https://github.com/re-taro) in [https://github.com/oxc-project/oxc/pull/1855](https://github.com/oxc-project/oxc/pull/1855)
-   eslint-plugin-jsx-a11y: html_has_lang by [@&#8203;msdlisper](https://github.com/msdlisper) in [https://github.com/oxc-project/oxc/pull/1843](https://github.com/oxc-project/oxc/pull/1843)

##### Suspicious

-   oxc: approx constant by [@&#8203;camc314](https://github.com/camc314) in [https://github.com/oxc-project/oxc/pull/1818](https://github.com/oxc-project/oxc/pull/1818)
-   oxc: misrefactored assign op by [@&#8203;camc314](https://github.com/camc314) in [https://github.com/oxc-project/oxc/pull/1832](https://github.com/oxc-project/oxc/pull/1832)

##### Restriction

-   react: button has type by [@&#8203;camc314](https://github.com/camc314) in [https://github.com/oxc-project/oxc/pull/1785](https://github.com/oxc-project/oxc/pull/1785)
-   unicorn: prefer modern math apis by [@&#8203;camc314](https://github.com/camc314) in [https://github.com/oxc-project/oxc/pull/1620](https://github.com/oxc-project/oxc/pull/1620)

#### Fixes

-   fix(linter): ignore anonymous functional components in arrays for eslint-plugin-react(jsx-key) by [@&#8203;maurice](https://github.com/maurice) in [https://github.com/oxc-project/oxc/pull/1858](https://github.com/oxc-project/oxc/pull/1858)
-   Prioritize ignored paths when linting by [@&#8203;clarkf](https://github.com/clarkf) in [https://github.com/oxc-project/oxc/pull/1878](https://github.com/oxc-project/oxc/pull/1878)
-   feat(linter): handle more cases for `const-comparisons` by [@&#8203;camc314](https://github.com/camc314) in [https://github.com/oxc-project/oxc/pull/1817](https://github.com/oxc-project/oxc/pull/1817)
-   feat(semantic): allow reserved keyword defined in ts module block by [@&#8203;Dunqing](https://github.com/Dunqing) in [https://github.com/oxc-project/oxc/pull/1907](https://github.com/oxc-project/oxc/pull/1907)
-   fix(parser): error on source larger than 4 GiB by [@&#8203;overlookmotel](https://github.com/overlookmotel) in [https://github.com/oxc-project/oxc/pull/1860](https://github.com/oxc-project/oxc/pull/1860)
-   fix(parser): fix incorrectly identified directives by [@&#8203;overlookmotel](https://github.com/overlookmotel) in [https://github.com/oxc-project/oxc/pull/1885](https://github.com/oxc-project/oxc/pull/1885)
-   fix(parser): terminate parsing if an EmptyParenthesizedExpression error occurs by [@&#8203;Dunqing](https://github.com/Dunqing) in [https://github.com/oxc-project/oxc/pull/1874](https://github.com/oxc-project/oxc/pull/1874)
-   fix(semantic): remove duplicate errors in ModuleDeclaration::ImportDeclaration by [@&#8203;Dunqing](https://github.com/Dunqing) in [https://github.com/oxc-project/oxc/pull/1846](https://github.com/oxc-project/oxc/pull/1846)
-   perf(linter): reduce the number of diagnostics for no_sparse_arrays by [@&#8203;camc314](https://github.com/camc314) in [https://github.com/oxc-project/oxc/pull/1895](https://github.com/oxc-project/oxc/pull/1895)

#### New Contributors

-   [@&#8203;maurice](https://github.com/maurice) made their first contribution in [https://github.com/oxc-project/oxc/pull/1858](https://github.com/oxc-project/oxc/pull/1858)
-   [@&#8203;re-taro](https://github.com/re-taro) made their first contribution in [https://github.com/oxc-project/oxc/pull/1855](https://github.com/oxc-project/oxc/pull/1855)
-   [@&#8203;DeividAlmeida](https://github.com/DeividAlmeida) made their first contribution in [https://github.com/oxc-project/oxc/pull/1835](https://github.com/oxc-project/oxc/pull/1835)
-   [@&#8203;XantreGodlike](https://github.com/XantreGodlike) made their first contribution in [https://github.com/oxc-project/oxc/pull/1862](https://github.com/oxc-project/oxc/pull/1862)
-   [@&#8203;Qix-](https://github.com/Qix-) made their first contribution in [https://github.com/oxc-project/oxc/pull/1861](https://github.com/oxc-project/oxc/pull/1861)
-   [@&#8203;yossydev](https://github.com/yossydev) made their first contribution in [https://github.com/oxc-project/oxc/pull/1831](https://github.com/oxc-project/oxc/pull/1831)
-   [@&#8203;clarkf](https://github.com/clarkf) made their first contribution in [https://github.com/oxc-project/oxc/pull/1878](https://github.com/oxc-project/oxc/pull/1878)
-   [@&#8203;zhangrunzhao](https://github.com/zhangrunzhao) made their first contribution in [https://github.com/oxc-project/oxc/pull/1890](https://github.com/oxc-project/oxc/pull/1890)

**Full Changelog**: oxc-project/oxc@oxlint_v0.0.22...oxlint_v0.1.1

### [`v0.1.0`](https://github.com/oxc-project/oxc/releases/tag/v0.1.0): CLI v0.1.0 Ezno Type Checker

[Compare Source](https://github.com/oxc-project/oxc/compare/a1accdca7f83694a6ea520d5cbfd090ea5dd271a...v0.1.0)

`npx oxidation-compiler@latest check ./test.ts`

![image](https://github.com/Boshen/oxc/assets/1430279/c7308395-1856-43fa-b4b8-b239886ec259)

#### New Contributors

-   [@&#8203;anonrig](https://github.com/anonrig) made their first contribution in [https://github.com/Boshen/oxc/pull/388](https://github.com/Boshen/oxc/pull/388)
-   [@&#8203;kaleidawave](https://github.com/kaleidawave) made their first contribution in [https://github.com/Boshen/oxc/pull/413](https://github.com/Boshen/oxc/pull/413)

**Full Changelog**: https://github.com/Boshen/oxc/compare/v0.0.7...

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/toeverything/AFFiNE).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEyMS4wIiwidGFyZ2V0QnJhbmNoIjoiY2FuYXJ5In0=-->

IWANABETHATGUY mentioned this pull request

jsx-no-undef #1928

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels