feat(linter): no-unknown-property for eslint-plugin-react

[XantreDev]

• tests: https://github.com/jsx-eslint/eslint-plugin-react/blob/master/tests/lib/rules/no-unknown-property.js
• docs: https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/no-unknown-property.md
• code: https://github.com/jsx-eslint/eslint-plugin-react/blob/master/lib/rules/no-unknown-property.js

[codspeed-hq]

CodSpeed Performance Report

Merging #1875 will not alter performance

_{Comparing XantreGodlike:react-no-unknown-property (46c7383) with main (f46ed71)}

Summary

✅ 14 untouched benchmarks

[XantreDev]

#1022

[XantreDev]

@camc314 Can u review it please?

[camc314]

This looks good to me.

I wonder whether some of the hashmaps -> vec strings should be converted to phf hash maps to improve performance.

e.g.

static ref ATTRIBUTE_TAGS_MAP: HashMap<&'static str, Vec<&'static str>> = HashMap::from([

would become

const ATTRIBUTE_TAGS_MAP: Map<&'static str, Map<&'static str, bool>> = phf_map! {
    /* entries */
};

The benchmarks show no perf regression, but currently, it doesn't look like we benchmark any large react codebases however this should be addressed by #1884.

[XantreDev]

This looks good to me.

I wonder whether some of the hashmaps -> vec strings should be converted to phf hash maps to improve performance.

e.g.

static ref ATTRIBUTE_TAGS_MAP: HashMap<&'static str, Vec<&'static str>> = HashMap::from([

would become

const ATTRIBUTE_TAGS_MAP: Map<&'static str, Map<&'static str, bool>> = phf_map! {
    /* entries */
};

The benchmarks show no perf regression, but currently, it doesn't look like we benchmark any large react codebases however this should be addressed by #1884.

I think replacement most of hash maps to compile time phc_map is a good idea.
I think Vec-s should be replaced with phc_set, not phc_map

[XantreDev]

Check Unused Dependencies have failed, because of unused rayon in language server, so I was forced to remove it from deps to pass CI

[camc314]

I think replacement most of hash maps to compile time phc_map is a good idea.
I think Vec-s should be replaced with phc_set, not phc_map

yeah that's what i mean - thank you

[camc314]

Thank you!

[camc314]

#1875 (comment)

looks like a false positive #1903 seems to have the same degregation