Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ls):support eslint config with lsp #1927

Closed
wants to merge 1 commit into from
Closed

feat(ls):support eslint config with lsp #1927

wants to merge 1 commit into from

Conversation

IWANABETHATGUY
Copy link
Contributor

@IWANABETHATGUY IWANABETHATGUY commented Jan 7, 2024 •
edited
Loading

  1. Closed oxc language server can not read lint configuration #1815
  2. Very basically support configuration, could improve in the future since our config is still under experimental.

imageconfig

{
  "rules": {
    "no-console": [
      "error",
      {
        "allow": [
          "info"
        ]
      }
    ]
  }
}

@IWANABETHATGUY IWANABETHATGUY changed the title support eslint config with lsp feat(lsp):support eslint config with lsp Jan 7, 2024
@IWANABETHATGUY IWANABETHATGUY changed the title feat(lsp):support eslint config with lsp feat(ls):support eslint config with lsp Jan 7, 2024
@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review January 7, 2024 15:47
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jan 7, 2024

CodSpeed Performance Report

Merging #1927 will not alter performance

Comparing IWANABETHATGUY:feat/eslint-config-support-with-lsp (c1fea37) with main (c6eb519)

Summary

✅ 14 untouched benchmarks

@IWANABETHATGUY IWANABETHATGUY requested a review from Boshen January 8, 2024 03:49
@IWANABETHATGUY
Copy link
Contributor Author

Sorry, I will reopen this pr after resolving the conflicts.

@IWANABETHATGUY IWANABETHATGUY deleted the feat/eslint-config-support-with-lsp branch January 8, 2024 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Boshen Boshen Awaiting requested review from Boshen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

oxc language server can not read lint configuration
1 participant
@IWANABETHATGUY