refactor(parser): remove TokenValue::Number from Token
#1945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is part of #1880. Token size is reduced from 40 to 32 bytes.
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
|
Note to self: number lexing no longer requires the string builder. |
CodSpeed Performance ReportMerging #1945 will not alter performanceComparing Summary
|
|
We can add a |
Dunqing
approved these changes
Jan 8, 2024
|
Looks great!! |
Boshen
deleted the
01-08-refactor_parser_remove_TokenValue_Number_from_Token
branch
Boshen
changed the title
Token
Boshen
changed the title
TokenTokenValue::Number from Token
Closed
|
Nice one! |
IWANABETHATGUY
pushed a commit
to IWANABETHATGUY/oxc
that referenced
this pull request
May 29, 2024
) This PR is part of oxc-project#1880. Token size is reduced from 40 to 32 bytes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of #1880.
Token size is reduced from 40 to 32 bytes.