Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(linter): eslint-plugin-import no-named-as-default-member rule #1988

Merged
merged 1 commit into from
Jan 15, 2024
Merged

feat(linter): eslint-plugin-import no-named-as-default-member rule #1988

merged 1 commit into from
Jan 15, 2024

Conversation

XantreDev
Copy link
Contributor

@XantreDev XantreDev commented Jan 11, 2024 •
edited
Loading

@github-actions github-actions bot added the A-linter Area - Linter label Jan 11, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jan 11, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #1988 will not alter performance

Comparing XantreGodlike:no-named-as-default-member (64de6e9) with main (21909fa)

Summary

✅ 14 untouched benchmarks

@XantreDev XantreDev changed the title No named as default member feat(linter): eslint-plugin-import no-named-as-default-member rule #1981 Jan 11, 2024
@XantreDev XantreDev changed the title feat(linter): eslint-plugin-import no-named-as-default-member rule #1981 feat(linter): eslint-plugin-import no-named-as-default-member rule Jan 11, 2024
@XantreDev XantreDev force-pushed the no-named-as-default-member branch 2 times, most recently from 708a1fa to b9c5eb0 Compare January 11, 2024 13:50
@XantreDev XantreDev marked this pull request as ready for review January 11, 2024 13:50
@XantreDev
Copy link
Contributor Author

#1117

@XantreDev XantreDev force-pushed the no-named-as-default-member branch from b9c5eb0 to 068e73d Compare January 12, 2024 21:15
@XantreDev
Copy link
Contributor Author

Will you merge it?)

@XantreDev
Copy link
Contributor Author

@mysteryven @Boshen

@Boshen Boshen force-pushed the no-named-as-default-member branch from 095182f to 84a3604 Compare January 15, 2024 10:54
@Boshen Boshen enabled auto-merge (squash) January 15, 2024 10:54
@github-actions github-actions bot added the A-prettier Area - Prettier label Jan 15, 2024
@Boshen
Copy link
Member

Boshen commented Jan 15, 2024

Thank you!

@Boshen Boshen force-pushed the no-named-as-default-member branch from 84a3604 to 64de6e9 Compare January 15, 2024 10:59
@Boshen Boshen merged commit c60c315 into oxc-project:main Jan 15, 2024
15 of 16 checks passed
mysteryven
mysteryven reviewed Jan 16, 2024
View reviewed changes
crates/oxc_linter/src/rules/import/no_named_as_default_member.rs
AstKind::VariableDeclarator(decl) => {
if let Some(Expression::MemberExpression(member_expr)) = &decl.init {
process_member_expr(member_expr);
return;
Copy link
Contributor

@mysteryven mysteryven Jan 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@XantreGodlike I know why, these return should be continue? 🙃 Change this will let the below case fail.

import baz from './named-exports';
{
    const baz = {};
    const a = baz.a;
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, will fix it in this week

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2071

@XantreDev XantreDev mentioned this pull request Jan 17, 2024
Merged
mysteryven pushed a commit that referenced this pull request Jan 18, 2024
@XantreDev
fix(linter): eslint-plugin-import no-named-as-default-member rule (#2071
d7ecd21 
)

Fixed false positives and early return @mysteryven 
#1988

https://github.com/oxc-project/oxc/pull/1988/files/64de6e9265d97d623d1f3a531b8c12a1a39dce02#r1453429430
IWANABETHATGUY pushed a commit to IWANABETHATGUY/oxc that referenced this pull request May 29, 2024
@XantreDev @IWANABETHATGUY
feat(linter): eslint-plugin-import no-named-as-default-member rule (o…
9cf4792 
…xc-project#1988)

- Docs:
https://github.com/import-js/eslint-plugin-import/blob/main/docs/rules/no-named-as-default-member.md
- Code:
https://github.com/import-js/eslint-plugin-import/blob/main/src/rules/no-named-as-default-member.js
- Tests:
https://github.com/import-js/eslint-plugin-import/blob/main/tests/src/rules/no-named-as-default-member.js
IWANABETHATGUY pushed a commit to IWANABETHATGUY/oxc that referenced this pull request May 29, 2024
@XantreDev @IWANABETHATGUY
fix(linter): eslint-plugin-import no-named-as-default-member rule (ox…
48ff90e 
…c-project#2071)

Fixed false positives and early return @mysteryven 
oxc-project#1988

https://github.com/oxc-project/oxc/pull/1988/files/64de6e9265d97d623d1f3a531b8c12a1a39dce02#r1453429430
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mysteryven mysteryven mysteryven approved these changes

Assignees
No one assigned
Labels
A-linter Area - Linter A-prettier Area - Prettier
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@XantreDev @Boshen @mysteryven