Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(linter): false positive with require-yield where yield is anywhere but function scope #2324

Closed
wants to merge 2 commits into from
Closed

fix(linter): false positive with require-yield where yield is anywhere but function scope #2324

wants to merge 2 commits into from

Conversation

maurice
Copy link
Contributor

@maurice maurice commented Feb 5, 2024

Fixes #2323

@github-actions github-actions bot added A-linter Area - Linter A-semantic Area - Semantic labels Feb 5, 2024
@Boshen Boshen self-requested a review February 5, 2024 13:26
@Boshen
Copy link
Member

Boshen commented Feb 5, 2024

I'll need to check the best place to fix this.

@maurice
Copy link
Contributor Author

maurice commented Feb 5, 2024

I'll need to check the best place to fix this.

Np, let me know if I can help

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Feb 5, 2024

CodSpeed Performance Report

Merging #2324 will not alter performance

⚠️ No base runs were found

Falling back to comparing maurice:fix-false-positive-require-yield-in-non-function-scope (4b7e8d4) with main (b27079c)

Summary

✅ 27 untouched benchmarks

Boshen added a commit that referenced this pull request Feb 5, 2024
@Boshen
chore(linter); add regression case for require-yield
3ef1e62 
closes #2323
closes #2324
@Boshen Boshen mentioned this pull request Feb 5, 2024
Merged
@Boshen Boshen closed this in #2326 Feb 5, 2024
Boshen added a commit that referenced this pull request Feb 5, 2024
@Boshen
chore(linter); add regression case for require-yield (#2326)
6fe9300 
closes #2323
closes #2324
@maurice maurice deleted the fix-false-positive-require-yield-in-non-function-scope branch February 5, 2024 15:32
IWANABETHATGUY pushed a commit to IWANABETHATGUY/oxc that referenced this pull request May 29, 2024
@Boshen @IWANABETHATGUY
chore(linter); add regression case for require-yield (oxc-project#2326)
879e7b5 
closes oxc-project#2323
closes oxc-project#2324
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Boshen Boshen Awaiting requested review from Boshen Boshen is a code owner

Assignees
No one assigned
Labels
A-linter Area - Linter A-semantic Area - Semantic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

False positive in require-yield where yield is anywhere but function scope
2 participants
@maurice @Boshen