-
-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tasks): shard linter benchmarks in CI #2752
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @overlookmotel and the rest of your teammates on Graphite |
CodSpeed Performance ReportMerging #2752 will not alter performanceComparing Summary
|
What's taking most of the time is building the benchmarks, not running them. @Boshen Is there any way to get Github Actions to cache the builds, so e.g. if a PR only makes changes to |
b927af6
to
6126b9f
Compare
Feels weird that |
@Boshen FYI, I did try out making sure only the crates which are needed for each benchmark get compiled, by disabling the rest with optional features: But this made no real difference to the build time. Almost all the time is spent building |
Follow-on from #2751. Further shards linter benchmarks so each fixture runs in its own job.
This reduces total time to run benchmarks by another ~75 secs. So approx 2.5 mins shaved off in total.