-
-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(index): fork index_vec
crate.
#3092
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Performance ReportMerging #3092 will not alter performanceComparing Summary
|
I intentionally didn't add a license file from the original crate so you can review and suggest how are we going to pay attribute to the author. |
I put licenses in https://github.com/oxc-project/oxc/blob/main/THIRD-PARTY-LICENSE And also mention this is a fork from index_vec on the top of the lib.rs file. |
Feel free to merge. |
a01f596
to
6b7a503
Compare
One bit of feedback: You can avoid compiling the In [dependencies]
- serde = { workspace = true }
+ serde = { workspace = true, optional = true }
[features]
- serialize = []
+ serialize = ["dep:serde"] |
@overlookmotel Oh thanks, I forgot to add the serde as optional. I'll fix it. |
related to #3086