ci: improve benchmark build time by only building once #3201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Boshen
changed the title
Boshen
force-pushed
the
bench-lto
branch
8 times, most recently
from
ae65d8a to
ffdd83f
Compare
CodSpeed Performance ReportMerging #3201 will not alter performanceComparing Summary
|
Boshen
changed the title
Boshen
changed the title
Boshen
pushed a commit
that referenced
this pull request
May 10, 2024
This PR builds on #3201 to further speed up the benchmarks and reduce CI time. * Build and run each benchmark as separate job (like before). * But now each bench is only built with the dependencies it needs. * For linter benchmarks, build benchmark in 1 job (like #3201 does). * Run each linter fixture in a separate job as they're slow. This reduces total time to complete benchmarks from between 6m-7m to ~4m40s. All the individual jobs complete in under 1m30s, except for building linter benchmark which takes 2m30s. So there won't be the problem of blocking the CI queue that there was before. NB: I did try this before, and didn't see a benefit. But I realized today what I was doing wrong - it only works once the caches are populated by a previous run on main branch. So the CI times in this PR won't look good, but once it's merged to main, it will take effect. Here it is running on main branch of my fork: https://github.com/overlookmotel/oxc/actions/runs/9030511348 I also added a step to delete the temp artefacts which aren't needed once the run has completed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates #3200