Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(coverage/transpiler): diff comparison results are reversed #3727

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Jun 17, 2024

image

Copy link
Member Author

Dunqing commented Jun 17, 2024

@Dunqing Dunqing marked this pull request as ready for review June 17, 2024 15:57
Copy link

graphite-app bot commented Jun 17, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link

codspeed-hq bot commented Jun 17, 2024

CodSpeed Performance Report

Merging #3727 will not alter performance

Comparing 06-17-fix_coverage_transpiler_diff_comparison_results_are_reversed (889198a) with main (8f64d99)

Summary

✅ 22 untouched benchmarks

Copy link

graphite-app bot commented Jun 17, 2024

Merge activity

@Boshen Boshen force-pushed the 06-17-fix_isolated-declarations_should_be_added_to_references_not_bindings branch from 2ca817a to 0fbecdc Compare June 17, 2024 16:47
@Boshen Boshen force-pushed the 06-17-fix_coverage_transpiler_diff_comparison_results_are_reversed branch from c54acc1 to 889198a Compare June 17, 2024 16:47
Base automatically changed from 06-17-fix_isolated-declarations_should_be_added_to_references_not_bindings to main June 17, 2024 16:50
@graphite-app graphite-app bot merged commit 889198a into main Jun 17, 2024
19 of 20 checks passed
@graphite-app graphite-app bot deleted the 06-17-fix_coverage_transpiler_diff_comparison_results_are_reversed branch June 17, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant