Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(semantic)!: no longer generate CFG by default. #3738

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

rzvxa
Copy link
Contributor

@rzvxa rzvxa commented Jun 18, 2024

related but won't close #3641

Copy link
Contributor Author

rzvxa commented Jun 18, 2024

Copy link

graphite-app bot commented Jun 18, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link

codspeed-hq bot commented Jun 18, 2024

CodSpeed Performance Report

Merging #3738 will improve performances by 13.23%

Comparing 06-18-chore_semantic_no_longer_generate_cfg_by_default (22b022c) with 06-18-chore_semantic_make_control_flow_generation_optional (d04848b)

Summary

⚡ 4 improvements
✅ 18 untouched benchmarks

Benchmarks breakdown

Benchmark 06-18-chore_semantic_make_control_flow_generation_optional 06-18-chore_semantic_no_longer_generate_cfg_by_default Change
transformer[antd.js] 402.8 ms 363.4 ms +10.82%
transformer[cal.com.tsx] 104.1 ms 97.5 ms +6.68%
transformer[checker.ts] 249.3 ms 220.1 ms +13.23%
transformer[pdf.mjs] 65 ms 57.8 ms +12.47%

@rzvxa rzvxa marked this pull request as ready for review June 18, 2024 14:43
@rzvxa rzvxa requested a review from Boshen June 18, 2024 14:43
@rzvxa rzvxa changed the title chore(semantic)!: no longer generate CFG by default. refactor(semantic)!: no longer generate CFG by default. Jun 18, 2024
@rzvxa rzvxa changed the title refactor(semantic)!: no longer generate CFG by default. chore(semantic)!: no longer generate CFG by default. Jun 18, 2024
@Boshen Boshen changed the base branch from 06-18-chore_semantic_make_control_flow_generation_optional to graphite-base/3738 June 18, 2024 15:31
Copy link

graphite-app bot commented Jun 18, 2024

Merge activity

@rzvxa rzvxa force-pushed the 06-18-chore_semantic_no_longer_generate_cfg_by_default branch from 22b022c to 0c9609f Compare June 18, 2024 15:36
@rzvxa rzvxa force-pushed the graphite-base/3738 branch from d04848b to 37adcb3 Compare June 18, 2024 15:36
@rzvxa rzvxa force-pushed the 06-18-chore_semantic_no_longer_generate_cfg_by_default branch 2 times, most recently from 535b3b9 to e688953 Compare June 18, 2024 15:40
@rzvxa rzvxa force-pushed the graphite-base/3738 branch from ccb7d32 to 8bfea7b Compare June 18, 2024 15:40
@Boshen Boshen force-pushed the 06-18-chore_semantic_no_longer_generate_cfg_by_default branch from e688953 to 83f024c Compare June 18, 2024 16:05
@Boshen Boshen changed the base branch from graphite-base/3738 to main June 18, 2024 16:06
@Boshen Boshen merged commit 256acc9 into main Jun 18, 2024
2 checks passed
@Boshen Boshen deleted the 06-18-chore_semantic_no_longer_generate_cfg_by_default branch June 18, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter A-semantic Area - Semantic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

semantic: make cfg construction optional
2 participants