Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ast): move the rest of ast implementations to ast_impl #3840

Conversation

rzvxa
Copy link
Contributor

@rzvxa rzvxa commented Jun 23, 2024

No description provided.

Copy link

graphite-app bot commented Jun 23, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the A-ast Area - AST label Jun 23, 2024
Copy link
Contributor Author

rzvxa commented Jun 23, 2024

@rzvxa rzvxa force-pushed the 06-23-chore_ast_move_the_rest_of_ast_implementations_to_ast_impl branch from 2422ed5 to 89d63cc Compare June 23, 2024 09:09
@rzvxa rzvxa requested a review from Boshen June 23, 2024 09:12
@rzvxa rzvxa marked this pull request as ready for review June 23, 2024 09:12
Copy link

codspeed-hq bot commented Jun 23, 2024

CodSpeed Performance Report

Merging #3840 will not alter performance

Comparing 06-23-chore_ast_move_the_rest_of_ast_implementations_to_ast_impl (f029273) with main (d76f34b)

Summary

✅ 28 untouched benchmarks

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Jun 23, 2024
Copy link

graphite-app bot commented Jun 23, 2024

Merge activity

  • Jun 23, 5:56 AM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jun 23, 5:56 AM EDT: Boshen added this pull request to the Graphite merge queue.
  • Jun 23, 6:01 AM EDT: Boshen merged this pull request with the Graphite merge queue.

@Boshen Boshen force-pushed the 06-23-chore_ast_move_the_rest_of_ast_implementations_to_ast_impl branch from 89d63cc to f029273 Compare June 23, 2024 09:56
@graphite-app graphite-app bot merged commit f029273 into main Jun 23, 2024
26 of 46 checks passed
@graphite-app graphite-app bot deleted the 06-23-chore_ast_move_the_rest_of_ast_implementations_to_ast_impl branch June 23, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-ast Area - AST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants