Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ast)!: rename all instances of BigintLiteral to BigIntLiteral. #3898

Merged
merged 1 commit into from
Jun 25, 2024
Merged

fix(ast)!: rename all instances of BigintLiteral to BigIntLiteral. #3898

merged 1 commit into from
Jun 25, 2024

Conversation

rzvxa
Copy link
Contributor

@rzvxa rzvxa commented Jun 25, 2024 •
edited
Loading

Notice the casing! Just for the sake of consistency.

@graphite-app Graphite App
Copy link

graphite-app bot commented Jun 25, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

This was referenced Jun 25, 2024
Merged
Merged
Merged
Merged
@rzvxa Graphite App
Copy link
Contributor Author

rzvxa commented Jun 25, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rzvxa and the rest of your teammates on Graphite Graphite

@rzvxa rzvxa mentioned this pull request Jun 25, 2024
Merged
@github-actions github-actions bot added A-linter Area - Linter A-parser Area - Parser A-semantic Area - Semantic A-minifier Area - Minifier A-ast Area - AST A-codegen Area - Code Generation A-prettier Area - Prettier labels Jun 25, 2024
@rzvxa rzvxa requested review from Boshen and overlookmotel June 25, 2024 08:07
@rzvxa rzvxa marked this pull request as ready for review June 25, 2024 08:07
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jun 25, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #3898 will not alter performance

Comparing 06-25-fix_ast_rename_all_instances_of_bigintliteral_to_bigintliteral_ (6796891) with main (f6c4ec4)

Summary

✅ 28 untouched benchmarks

@rzvxa rzvxa force-pushed the 06-23-feat_ast_codegen_add_implgetspangenerator_ branch from 6b7bd27 to 7c0c756 Compare June 25, 2024 09:02
@rzvxa rzvxa force-pushed the 06-25-fix_ast_rename_all_instances_of_bigintliteral_to_bigintliteral_ branch from 7a2d4b3 to 66c4d42 Compare June 25, 2024 09:02
@rzvxa rzvxa force-pushed the 06-23-feat_ast_codegen_add_implgetspangenerator_ branch from 7c0c756 to 5a51be3 Compare June 25, 2024 09:31
@rzvxa rzvxa force-pushed the 06-25-fix_ast_rename_all_instances_of_bigintliteral_to_bigintliteral_ branch from 66c4d42 to 26a4631 Compare June 25, 2024 09:31
@rzvxa rzvxa mentioned this pull request Jun 25, 2024
Merged
overlookmotel
overlookmotel approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@overlookmotel overlookmotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for splitting this out into a separate PR.

If you want to move this to the bottom of the stack, we could get it merged now. Or leave it where it is - whichever is easier.

@rzvxa
Copy link
Contributor Author

rzvxa commented Jun 25, 2024

Thanks for splitting this out into a separate PR.

If you want to move this to the bottom of the stack, we could get it merged now. Or leave it where it is - whichever is easier.

I thought stack is approved up until #3890 which is WIP, Am I wrong about that?

@Boshen Boshen force-pushed the 06-23-feat_ast_codegen_add_implgetspangenerator_ branch from 5a51be3 to f0b7a57 Compare June 25, 2024 09:48
@Boshen Boshen force-pushed the 06-25-fix_ast_rename_all_instances_of_bigintliteral_to_bigintliteral_ branch from 26a4631 to e2b4b86 Compare June 25, 2024 09:49
@rzvxa rzvxa force-pushed the 06-23-feat_ast_codegen_add_implgetspangenerator_ branch from f0b7a57 to 9c7d50f Compare June 25, 2024 10:36
@rzvxa rzvxa force-pushed the 06-25-fix_ast_rename_all_instances_of_bigintliteral_to_bigintliteral_ branch from e2b4b86 to ca83fd7 Compare June 25, 2024 10:36
@overlookmotel
Copy link
Contributor

I thought stack is approved up until #3890 which is WIP, Am I wrong about that?

I saw you making more changes to #3815 and that it was draft again. Wasn't sure how much work that was going to be. I see that's now ready, so yeah no point in reordering the stack.

@Boshen Boshen changed the title fix(ast): rename all instances of BigintLiteral to BigIntLiteral. fix(ast)!: rename all instances of BigintLiteral to BigIntLiteral. Jun 25, 2024
@graphite-app Graphite App
Copy link

graphite-app bot commented Jun 25, 2024 •
edited
Loading

Merge activity

@Boshen Boshen force-pushed the 06-23-feat_ast_codegen_add_implgetspangenerator_ branch from 9c7d50f to 6a51f3c Compare June 25, 2024 13:55
Boshen pushed a commit that referenced this pull request Jun 25, 2024
@rzvxa
fix(ast)!: rename all instances of BigintLiteral to BigIntLiteral. (
b4a1f03 
#3898)

Notice the casing! Just for the sake of consistency.
@Boshen Boshen force-pushed the 06-25-fix_ast_rename_all_instances_of_bigintliteral_to_bigintliteral_ branch from ca83fd7 to b4a1f03 Compare June 25, 2024 13:56
rzvxa added a commit that referenced this pull request Jun 25, 2024
@rzvxa
fix(ast)!: rename all instances of BigintLiteral to BigIntLiteral. (
3ec6fa9 
#3898)

Notice the casing! Just for the sake of consistency.
@rzvxa rzvxa force-pushed the 06-25-fix_ast_rename_all_instances_of_bigintliteral_to_bigintliteral_ branch from b4a1f03 to 3ec6fa9 Compare June 25, 2024 14:33
@rzvxa
fix(ast)!: rename all instances of BigintLiteral to BigIntLiteral. (
6796891 
#3898)

Notice the casing! Just for the sake of consistency.
@rzvxa rzvxa force-pushed the 06-23-feat_ast_codegen_add_implgetspangenerator_ branch from 3de2494 to 09f4d3c Compare June 25, 2024 14:39
@rzvxa rzvxa force-pushed the 06-25-fix_ast_rename_all_instances_of_bigintliteral_to_bigintliteral_ branch from 3ec6fa9 to 6796891 Compare June 25, 2024 14:40
@rzvxa rzvxa changed the base branch from 06-23-feat_ast_codegen_add_implgetspangenerator_ to main June 25, 2024 14:43
@graphite-app graphite-app bot merged commit 6796891 into main Jun 25, 2024
26 checks passed
@graphite-app graphite-app bot deleted the 06-25-fix_ast_rename_all_instances_of_bigintliteral_to_bigintliteral_ branch June 25, 2024 14:45
This was referenced Jun 26, 2024
Merged
Closed
Closed
Merged
Boshen added a commit that referenced this pull request Jun 27, 2024
@github-actions @Boshen
Release oxlint v0.5.0 (#3940)
06e4ce4 
## [0.5.0] - 2024-06-27

- 6796891 ast: [**BREAKING**] Rename all instances of `BigintLiteral` to
`BigIntLiteral`. (#3898) (rzvxa)

- ae09a97 ast: [**BREAKING**] Remove `Modifiers` from ts nodes (#3846)
(Boshen)

- 1af5ed3 ast: [**BREAKING**] Replace `Modifiers` with `declare` and
`const` on `EnumDeclaration` (#3845) (Boshen)

- ee6ec4e ast: [**BREAKING**] Replace `Modifiers` with `declare` and
`abstract` on `Class` (#3841) (Boshen)

- 4456034 ast: [**BREAKING**] Add `IdentifierReference` to
`ExportSpecifier` (#3820) (Boshen)

- 0537d29 cfg: [**BREAKING**] Move control flow to its own crate.
(#3728) (rzvxa)

- 5c38a0f codegen: [**BREAKING**] New code gen API (#3740) (Boshen)

- 4bce59d semantic/cfg: [**BREAKING**] Re-export `petgraph` as
`control_flow::graph`. (#3722) (rzvxa)

### Features

- 3ae2628 linter: Change `no-import-assign` to correctness (#3928)
(Boshen)
- a89d501 linter: Implement
@typescript-eslint/no-non-null-asserted-nulli… (#3850) (kaykdm)
- fc48cb4 linter: �eslint-plugin-jest/prefer-jest-mocked (#3865)
(cinchen)
- 63b98bd linter: Accept multiple fixes when fix code (#3842)
(mysteryven)
- 328445b linter: Support `vitest/no-disabled-tests` (#3717)
(mysteryven)
- 8c61f9c linter: Implement @typescript-eslint/no-non-null-assertion
(#3825) (kaykdm)
- 080ecbd linter: Add `no-fallthrough`. (#3673) (rzvxa)
- 9493fbe linter: Add `oxc/no-optional-chaining` rule (#3700)
(mysteryven)
- 139adfe linter: Add `@typescript-eslint/no-import-type-side_effects`
(#3699) (mysteryven)
- 5f84500 linter/eslint-plugin-react: Implement prefer-es6-class (#3812)
(Jelle van der Waa)
- fafe67c linter/import: Implement max-dependencies (#3814) (Jelle van
der Waa)
- d5f6aeb semantic: Check for illegal symbol modifiers (#3838) (Don
Isaac)

### Bug Fixes

- 4bd2c88 linter: Fix and promote `getter-return` to correctness.
(#3777) (rzvxa)
- 1190dee linter: False positives with setters in the `getter-return`
rule. (#3714) (rzvxa)
- de0690f linter: Do not run getter-return in typescript (#3693)
(Boshen)
- cf71c23 linter: Edge case with infinite loops. (#3672) (rzvxa)
- 5902331 oxlint: Properly report error (#3889) (Luca Bruno)
- 99a40ce semantic: `export default foo` should have
`ExportLocalName::Default(NameSpan)` entry (#3823) (Boshen)
- abd6ac8 semantic/cfg: Discrete finalization path after `NewFunction`s.
(#3671) (rzvxa)

### Performance
- 4f7ff7e Do not pass `&Atom` to functions (#3818) (overlookmotel)

### Refactor

- 4d2b7f1 linter: `LintContext` can now only be constructed with a cfg
enabled semantic. (#3761) (rzvxa)
- 7302429 linter/prefer_number_properties: Remove the unused
`IdentifierName` check (#3822) (Boshen)
- d8ad321 semantic: Make control flow generation optional. (#3737)
(rzvxa)

### Testing

- 887da40 linter: Enable `no-fallthrough` test with `disable-next-line`.
(#3766) (rzvxa)

Co-authored-by: Boshen <Boshen@users.noreply.github.com>
@github-actions github-actions bot mentioned this pull request Jun 27, 2024
Closed
Boshen added a commit that referenced this pull request Jun 27, 2024
@github-actions @Boshen
Release crates v0.16.0 (#3930)
4e3e1a3 
## [0.16.0] - 2024-06-26

- 6796891 ast: [**BREAKING**] Rename all instances of `BigintLiteral` to
`BigIntLiteral`. (#3898) (rzvxa)

- 1f85f1a ast: [**BREAKING**] Revert adding `span` field to the
`BindingPattern` type. (#3899) (rzvxa)

- ae09a97 ast: [**BREAKING**] Remove `Modifiers` from ts nodes (#3846)
(Boshen)

- 1af5ed3 ast: [**BREAKING**] Replace `Modifiers` with `declare` and
`const` on `EnumDeclaration` (#3845) (Boshen)

- 0673677 ast: [**BREAKING**] Replace `Modifiers` with `declare` on
`Function` (#3844) (Boshen)

- ee6ec4e ast: [**BREAKING**] Replace `Modifiers` with `declare` and
`abstract` on `Class` (#3841) (Boshen)

- 9b38119 ast: [**BREAKING**] Replace `Modifiers` with `declare` on
`VariableDeclaration` (#3839) (Boshen)

- cfcef24 ast: [**BREAKING**] Add `directives` field to `TSModuleBlock`
(#3830) (Boshen)

- 4456034 ast: [**BREAKING**] Add `IdentifierReference` to
`ExportSpecifier` (#3820) (Boshen)

### Features

- 497769c ast: Add some visitor functions (#3785) (Dunqing)
- 4b06dc7 ast: Add TSType::TSIntrinsicKeyword to is_keyword (#3775)
(Dunqing)
- 5847e16 ast,parser: Add `intrinsic` keyword (#3767) (Boshen)
- 2e026e1 ast_codegen: Generate `ast_kind.rs`. (#3888) (rzvxa)
- 09f4d3c ast_codegen: Add `ImplGetSpanGenerator`. (#3852) (rzvxa)
- 3e78f98 cfg: Add depth first search with hash sets. (#3771) (rzvxa)
- 01da2f7 codegen: Print TSThisParameter for TSCallSignatureDeclaration
and TSMethodSignature (#3792) (Dunqing)
- 2821e0e codegen: Print readonly keyword for TSIndexSignature (#3791)
(Dunqing)
- 97575d8 codegen: Print TSClassImplements and TSThisParameter (#3786)
(Dunqing)
- 5e2baf3 isolated-declarations: Report error for expando functions
(#3872) (Dunqing)
- 2cdb34f isolated-declarations: Support for class function overloads
(#3811) (Dunqing)
- 231b8f0 isolated-declarations: Support for export default function
overloads (#3809) (Dunqing)
- a37138f isolated-declarations: Improve the inference template literal
(#3797) (Dunqing)
- b0d7355 isolated-declarations: Transform const expression correctly
(#3793) (Dunqing)
- b38c34d isolated-declarations: Support inferring
ParenthesizedExpression (#3769) (Dunqing)
- 4134de8 isolated-declarations: Add ts error code to the error message
(#3755) (Dunqing)
- 94202de isolated-declarations: Add `export {}` when needed (#3754)
(Dunqing)
- e95d8e3 isolated-declarations: Shrink span for arrow function that
needs an explicit return type (#3752) (Dunqing)
- df9971d isolated-declarations: Improve inferring the return type from
function (#3750) (Dunqing)
- 4aea2b1 isolated-declarations: Improve inferring the type of accessor
(#3749) (Dunqing)
- 9ea30c4 isolated-declarations: Treat AssignmentPattern as optional
(#3748) (Dunqing)
- dd540c8 minifier: Add skeleton for ReplaceGlobalDefines ast pass
(#3803) (Boshen)
- f3c3970 minifier: Add skeleton for RemoveDeadCode ast pass (#3802)
(Boshen)
- 4fb90eb oxc: Export isolated-declarations (#3765) (Boshen)
- d5f6aeb semantic: Check for illegal symbol modifiers (#3838) (Don
Isaac)
- 01572f0 sourcemap: Impl `std::fmt::Display` for `Error` (#3902)
(DonIsaac)
- 5501d5c transformer/typescript: Transform `import {} from "mod"` to
import `"mod"` (#3866) (Dunqing)
- 2a16ce0 traverse: Disable syntax check and disable build module record
(#3794) (Boshen)- d3cd3ea Oxc transform binding (#3896) (underfin)

### Bug Fixes

- 063cfde ast: Correct JSON serialization of `TSModuleBlock` (#3858)
(overlookmotel)
- 66f404c ast: Fix JSON serialization of `BindingPattern` (#3856)
(overlookmotel)
- 2766594 codegen: Print type parameters for MethodDefinition (#3922)
(Dunqing)
- 27f0531 isolated-declarations: Private constructor reaching
unreachable (#3921) (Dunqing)
- 59ce38b isolated-declarations: Inferring of UnrayExpression
incorrectly (#3920) (Dunqing)
- 58e54f4 isolated-declarations: Report an error for parameters if they
are ObjectPattern or ArrayPattern without an explicit type (#3810)
(Dunqing)
- cb8a272 isolated-declarations: Cannot infer nested `as const` (#3807)
(Dunqing)
- d8ecce5 isolated-declarations: Infer BigInt number as `bigint` type
(#3806) (Dunqing)
- 4e241fc isolated-declarations: Missing `const` after transformed const
enum (#3805) (Dunqing)
- 683c7b0 isolated-declarations: Shouldn’t add declare in declaration
with export default (#3804) (Dunqing)
- 7d47fc3 isolated-declarations: Should stripe async and generator
keyword after transformed (#3790) (Dunqing)
- 8ce794d isolated-declarations: Inferring an incorrect return type when
there is an arrow function inside a function (#3768) (Dunqing)
- d29316a isolated-declarations: Transform incorrectly when there are
multiple functions with the same name (#3753) (Dunqing)
- bf1c250 isolated-declarations: False positives for non-exported
binding elements (#3751) (Dunqing)
- 275349a parser: Parse function type parameter name `accessor` (#3926)
(Boshen)
- ef82c78 parser: Trailing comma is not allowed in
ParenthesizedExpression (#3885) (Dunqing)
- 13754cb parser: Change diagnostic to "modifier cannot be used here"
(#3853) (Boshen)
- 8c9fc63 semantic: Apply strict mode scope flag for strict mode TS
Modules (#3861) (overlookmotel)
- 99a40ce semantic: `export default foo` should have
`ExportLocalName::Default(NameSpan)` entry (#3823) (Boshen)
- 08fcfb3 transformer: Fix spans and scopes in TS enum transform (#3911)
(overlookmotel)
- 17ad8f7 transformer: Create new scopes for new blocks in TS transform
(#3908) (overlookmotel)
- d76f34b transformer: TODO comments for missing scopes (#3837)
(overlookmotel)
- e470731 transformer: TS transform handle when type exports first
(#3833) (overlookmotel)
- d774e54 transformer: TS transform generate do not copy statements
(#3832) (overlookmotel)
- ff1da27 transformer: Correct comment in example (#3831)
(overlookmotel)
- 6dcc3f4 transformer: Fix TS annotation transform scopes (#3816)
(overlookmotel)
- aea3e9a transformer: Correct spans for TS annotations transform
(#3782) (overlookmotel)

### Performance

- 92c21b2 diagnostics: Optimize string-buffer reallocations (#3897)
(Luca Bruno)
- 4bf405d parser: Add a few more inline hints to cursor functions
(#3894) (Boshen)
- 10d1de5 semantic: Remove uneccessary allocation in builder (#3867)
(DonIsaac)- 4f7ff7e Do not pass `&Atom` to functions (#3818)
(overlookmotel)

### Refactor

- 6f26087 ast: Add comment about alternatives to `AstBuilder::copy`
(#3905) (overlookmotel)
- 442aca3 ast: Add comment not to use `AstBuilder::copy` (#3891)
(overlookmotel)
- acf69fa ast: Refactor custom `Serialize` impls (#3859) (overlookmotel)
- 9e148e9 ast: Add line breaks (#3860) (overlookmotel)
- 363d3d5 ast: Add span field to the `BindingPattern` type. (#3855)
(rzvxa)
- a648748 ast: Shorten code in AST builder (#3835) (overlookmotel)
- 1206967 ast: Reduce allocations in AST builder (#3834) (overlookmotel)
- 2f5d50e isolated-declarations: Remove `Modifiers` (#3847) (Boshen)
- 8027b1e minifier: Change prepass to ast_passes::remove_parens (#3801)
(Boshen)
- a471e62 parser: Clean up `try_parse` (#3925) (Boshen)
- 3db2553 parser: Improve parsing of TypeScript type arguments (#3923)
(Boshen)
- 4cf3c76 parser: Improve parsing of TypeScript types (#3903) (Boshen)
- 187f078 parser: Improve parsing of
`parse_function_or_constructor_type` (#3892) (Boshen)
- 97d59fc parser: Move code around for parsing `Modifiers` (#3849)
(Boshen)
- 5ef28b7 transformer: Shorten code (#3912) (overlookmotel)
- d9f268d transformer: Shorten TS transform code (#3836) (overlookmotel)
- 21b0d01 transformer: Pass ref to function (#3781) (overlookmotel)
- 7c44703 transformer: Remove needless `pub` on TS enum transform
methods (#3774) (overlookmotel)
- 22c56d7 transformer: Move TSImportEqualsDeclaration transform code
(#3764) (overlookmotel)
- cd56aa9 transformer: Simplify TS export assignment transform (#3762)
(overlookmotel)
- 512740d transformer: Move and simplify TS enum transform entry point
(#3760) (overlookmotel)
- 1061baa traverse: Separate `#[scope]` attr (#3901) (overlookmotel)
- fcd21a6 traverse: Indicate scope entry point with
`scope(enter_before)` attr (#3882) (overlookmotel)
- 24979c9 traverse: Use camel case props internally (#3880)
(overlookmotel)
- 2045c92 traverse: Improve parsing attrs in traverse codegen (#3879)
(overlookmotel)- d6437fe Clean up some usages of `with_labels` (#3854)
(Boshen)

Co-authored-by: Boshen <Boshen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@overlookmotel overlookmotel overlookmotel approved these changes

@Boshen Boshen Awaiting requested review from Boshen Boshen is a code owner

Assignees
No one assigned
Labels
A-ast Area - AST A-codegen Area - Code Generation A-linter Area - Linter A-minifier Area - Minifier A-parser Area - Parser A-prettier Area - Prettier A-semantic Area - Semantic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rzvxa @overlookmotel