feat(linter): eslint/no-else-return

[poyoho]

No description provided.

[graphite-app]

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

[codspeed-hq]

CodSpeed Performance Report

Merging #4305 will not alter performance

_{Comparing poyoho:feat/no-else-return (b301068) with main (a949ecb)}

Summary

✅ 29 untouched benchmarks

[rzvxa]

Hi, First off thanks for your contribution😍

I have some thoughts on this, I know the eslint rule is implemented in the same way you've implemented this one. But the performance isn't so great with this approach.
That's why I was thinking maybe we can use the control flow graph for this purpose instead. But that would require a major change in what you've already done.

So before going with that - or ruling it out - is it possible for you to do these 2 experiments to see the benchmark for it?

1. running the rule on return statements and going up to see if we are in an if statement or not(which IMHO I think wouldn't improve the performance or even worse it might degrade it further)
2. running the rule on node.is_function_likes and check they contain an appropriate if statement to lint(+ checking the top-level ifs with return)

@mysteryven @DonIsaac Do you guys want to chime in?

Side note: It seems like this PR still is a work in progress, It would be better if you keep a WIP PR as Draft and only mark it for review when it is ready to be reviewed and merged.

[poyoho]

I tinker repeatedly executing always_return on the same if_stmt to make the performace bad. may be I can save the if_stmt the result of always_return the reduce run this function?

As you said, use the node.is_function_like reduce the Rule::run function exec, and cache the alway_returns(if_stmt) run result.

[DonIsaac]

hey @poyoho 👋 thanks so much for your PR! Do you need some help getting this PR over the finish line?

[poyoho]

I will try again

[DonIsaac]

👏 👏 👏

[poyoho]

Do you know how to fix CI / Test (ubuntu-latest) and CI / Test (macos-14) @DonIsaac

[DonIsaac]

You need to specify a fix kind in declare_oxc_lint. Check out other rules for examples.

[DonIsaac]

🎉🎉🎉