Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(semantic): grow unresolved_references by doubling #4387

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Jul 21, 2024

Grow stack of unresolved references by doubling rather than incrementing. This will initialize more entries than required in some cases, but in return it makes the branch on when to grow more predictable.

Copy link

graphite-app bot commented Jul 21, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

overlookmotel commented Jul 21, 2024

@Dunqing Dunqing changed the base branch from 07-21-perf_semantic_remove_a_branch_from_add_scope_ to main July 21, 2024 12:47
@overlookmotel overlookmotel marked this pull request as ready for review July 21, 2024 12:48
@overlookmotel overlookmotel marked this pull request as draft July 21, 2024 12:48
Copy link

codspeed-hq bot commented Jul 21, 2024

CodSpeed Performance Report

Merging #4387 will not alter performance

Comparing 07-21-perf_semantic_grow_unresolved_references_by_doubling (4dd2c9a) with main (e70c67b)

Summary

✅ 32 untouched benchmarks

@overlookmotel
Copy link
Contributor Author

Run the benchmarks 3 times. 2 out of 3 times it was a perf regression, and 3rd time only a minor gain. So closing.

@overlookmotel overlookmotel deleted the 07-21-perf_semantic_grow_unresolved_references_by_doubling branch July 21, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-semantic Area - Semantic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant