-
-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(docs): mark eslint and typescript alias rules as implemented, #4611
Conversation
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
||
/** @param {import("eslint").Linter} linter */ | ||
const loadPluginTypeScriptRules = (linter) => { | ||
// We want to list all rules but not support type-checked rules | ||
const pluginTypeScriptDisableTypeCheckedRules = new Map( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont know why this rules were excluded. When I keep this line I get a warning:
👀 typescript/require-await is implemented but not found in their rules
Also this bumps the total rules:
There are 123(+ 26 deprecated) rules.
- 41/75 recommended rules are remaining as TODO
- 38/48 not recommended rules are remaining as TODO
@@ -242,6 +285,9 @@ exports.ALL_TARGET_PLUGINS = new Map([ | |||
], | |||
["react-perf", { npm: ["eslint-plugin-react-perf"], issueNo: 2041 }], | |||
["nextjs", { npm: ["@next/eslint-plugin-next"], issueNo: 1929 }], | |||
["promise", { npm: ["eslint-plugin-promise"], issueNo: 9999 }], // TODO! | |||
["vitest", { npm: ["eslint-plugin-vitest"], issueNo: 9999 }], // TODO! | |||
["tree-shaking", { npm: ["eslint-plugin-tree-shaking"], issueNo: 9999 }], // TODO! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tree-shaking has only one rule in node and in oxc.
You should know better if an Tracking-Issue should be created or not ;)
@Sysix Hey, thanks for the initiative! Looking at the code diff, it appears that the content and title of the PR do not match? And I have addressed the part of updating the Therefore, can I ask you to reduce the scope of this PR to the part that tracks the status of @Boshen Would you please create a ☂️ issue for |
Closes #4085