Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ast_codegen): disallow implicit enum discriminants on #[ast] types. #4690

Conversation

rzvxa
Copy link
Contributor

@rzvxa rzvxa commented Aug 6, 2024

No description provided.

Copy link

graphite-app bot commented Aug 6, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

rzvxa commented Aug 6, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rzvxa and the rest of your teammates on Graphite Graphite

Copy link

codspeed-hq bot commented Aug 6, 2024

CodSpeed Performance Report

Merging #4690 will not alter performance

Comparing 08-06-refactor_ast_codegen_disallow_implicit_enum_discriminants_on_ast_types (b04dc3d) with main (e24fb5b)

Summary

✅ 29 untouched benchmarks

@rzvxa rzvxa force-pushed the 08-06-refactor_ast_codegen_move_away_from_rtype_in_generators branch from b691815 to 1350541 Compare August 6, 2024 13:58
@rzvxa rzvxa force-pushed the 08-06-refactor_ast_codegen_disallow_implicit_enum_discriminants_on_ast_types branch from a81ac51 to c8a643d Compare August 6, 2024 13:58
@rzvxa rzvxa force-pushed the 08-06-refactor_ast_codegen_move_away_from_rtype_in_generators branch from 1350541 to 05d5cd6 Compare August 6, 2024 14:44
@rzvxa rzvxa force-pushed the 08-06-refactor_ast_codegen_disallow_implicit_enum_discriminants_on_ast_types branch from c8a643d to da86af3 Compare August 6, 2024 14:44
@rzvxa rzvxa marked this pull request as ready for review August 6, 2024 15:43
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Aug 6, 2024
Copy link

graphite-app bot commented Aug 6, 2024

Merge activity

  • Aug 6, 1:09 PM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Aug 6, 1:11 PM EDT: overlookmotel added this pull request to the Graphite merge queue.
  • Aug 6, 1:21 PM EDT: overlookmotel merged this pull request with the Graphite merge queue.

@overlookmotel overlookmotel force-pushed the 08-06-refactor_ast_codegen_move_away_from_rtype_in_generators branch from 05d5cd6 to 1690a57 Compare August 6, 2024 17:14
@overlookmotel overlookmotel force-pushed the 08-06-refactor_ast_codegen_disallow_implicit_enum_discriminants_on_ast_types branch from da86af3 to b04dc3d Compare August 6, 2024 17:15
@overlookmotel overlookmotel changed the base branch from 08-06-refactor_ast_codegen_move_away_from_rtype_in_generators to main August 6, 2024 17:20
@graphite-app graphite-app bot merged commit b04dc3d into main Aug 6, 2024
24 checks passed
@graphite-app graphite-app bot deleted the 08-06-refactor_ast_codegen_disallow_implicit_enum_discriminants_on_ast_types branch August 6, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants