Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ast_codegen): list input files explicitly #4708

Merged

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Aug 6, 2024

List inputs to the codegen explicitly. This is less DRY, but I think it has the advantage of being more obvious - for oxc-project/backlog#124.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on Graphite Graphite

Copy link

graphite-app bot commented Aug 6, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@overlookmotel overlookmotel force-pushed the 08-06-refactor_ast_codegen_list_input_files_explicitly branch from 2c28663 to ff210a3 Compare August 6, 2024 19:07
@overlookmotel overlookmotel marked this pull request as ready for review August 6, 2024 19:10
@rzvxa rzvxa added the 0-merge Merge with Graphite Merge Queue label Aug 6, 2024
Copy link

graphite-app bot commented Aug 6, 2024

Merge activity

  • Aug 6, 3:13 PM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Aug 6, 3:13 PM EDT: rzvxa added this pull request to the Graphite merge queue.
  • Aug 6, 3:17 PM EDT: rzvxa merged this pull request with the Graphite merge queue.

List inputs to the codegen explicitly. This is less DRY, but I think it has the advantage of being more obvious - for #4704.
@rzvxa rzvxa force-pushed the 08-06-refactor_ast_codegen_list_input_files_explicitly branch from ff210a3 to 654a6e6 Compare August 6, 2024 19:14
@graphite-app graphite-app bot merged commit 654a6e6 into main Aug 6, 2024
24 checks passed
@graphite-app graphite-app bot deleted the 08-06-refactor_ast_codegen_list_input_files_explicitly branch August 6, 2024 19:17
Copy link

codspeed-hq bot commented Aug 6, 2024

CodSpeed Performance Report

Merging #4708 will not alter performance

Comparing 08-06-refactor_ast_codegen_list_input_files_explicitly (654a6e6) with main (07607d3)

Summary

✅ 29 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants