feat(linter): add fix emoji to rules table and doc pages #4715

DonIsaac · 2024-08-06T22:46:02Z

Rules table:

Doc pages:

DonIsaac · 2024-08-06T22:46:21Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @DonIsaac and the rest of your teammates on Graphite

codspeed-hq · 2024-08-06T22:57:57Z

CodSpeed Performance Report

Merging #4715 will not alter performance

_{Comparing don/08-06-feat_linter_add_fix_emoji_to_rules_table (3d40528) with main (a266b45)}

Summary

✅ 29 untouched benchmarks

crates/oxc_linter/src/fixer/fix.rs

tasks/website/src/linter/rules/test.rs

camc314

nice stuff!

graphite-app · 2024-08-10T22:48:51Z

Merge activity

Aug 10, 6:48 PM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Aug 10, 6:51 PM EDT: DonIsaac added this pull request to the Graphite merge queue.
Aug 10, 6:54 PM EDT: DonIsaac merged this pull request with the Graphite merge queue.

Rules table: <img width="898" alt="image" src="https://github.com/user-attachments/assets/353052aa-0af3-4c09-8441-ff79f4561ca0"> Doc pages: <img width="918" alt="image" src="https://github.com/user-attachments/assets/cb43cb2d-15ff-41e6-8523-145cfbc3f484">

## [0.7.1] - 2024-08-12 ### Features - 3d40528 linter: Add fix emoji to rules table and doc pages (#4715) (DonIsaac) - d2734f3 linter: Start fixer for no-unused-vars (#4718) (DonIsaac) - 070ae53 linter: Add fixer for unicorn prefer-string-replace-all (#4801) (camc314) - b3c3125 linter: Overhaul unicorn/no-useless-spread (#4791) (DonIsaac) - 5992b75 linter: Implement `eslint-plugin-promise/no-return-in-finally, prefer-await-to-then` rule (#4318) (Jelle van der Waa) - b259f47 linter: Add fixer for unicorn/no-length-as-slice-end (#4780) (heygsc) - abd83fa linter: Add fixer for jsx_ally/no_aria_hidden_on_focusable (#4772) (heygsc) - b20e335 linter: Add fixer for eslint/no-eq-null (#4758) (heygsc) - 2f6c3b9 linter: Add fixer for eslint/no-compare-neg-zero (#4748) (heygsc) - eaddc8f linter: Add fixer for eslint/func_names (#4714) (DonIsaac) - 80557a9 linter: Add fixer for eslint/for-direction (#4679) (heygsc) - c3c5766 linter/eslint-plugin-promise: Implement valid-params (#4598) (Jelle van der Waa) - c509a21 linter/eslint-plugin-vitest: Implement prefer-to-be-falsy (#4770) (dalaoshu) - 41f861f linter/eslint-plugin-vitest: Implement prefer-to-be-truthy (#4755) (dalaoshu) - cc922f4 vscode: Provide config's schema to oxlint config files (#4826) (Don Isaac) - f629514 website: Auto-generate rule docs pages (#4640) (DonIsaac) ### Bug Fixes - b22ed45 linter: Improve prefer_namespace_keyword rule (#4751) (Burlin) - db68a6c linter: Fixer for eslint/for-direction (#4727) (heygsc) - 6273994 linter: Block in eslint/no_cond_assign (#4721) (heygsc) - b9d6aa5 linter: Fix false positives in no-confusing-non-null-assertion (#4665) (Renée) - cbf08d2 linter: Skip no-multi-str on jsx attributes (#4666) (heygsc) - a6f9f96 linter: No unused errors should be warnings (Boshen) - 7345bc9 linter/func-names: Handle ts accessibility when reporting missing names (#4713) (DonIsaac) ### Performance - d191823 linter: Optmize allocations in jest fn parsing (#4787) (lucab) - e3abdfa linter: Reduce String allocations and clones (#4673) (DonIsaac) ### Documentation - 4b7dfd6 linter: Correct docs for no-unused-vars (#4716) (Don Isaac) ### Refactor - 096ac7b linter: Clean up jsx-a11y/anchor-is-valid (#4831) (DonIsaac) - 15a0fd4 linter: Use Option to reduce nested level in `eslint/getter-return` (#4814) (IWANABETHATGUY) - 63f274c linter: Simplify NoObjCalls resolution logic (#4765) (lucab) - 6708680 linter: Replace Windows-style line breaks with Unix-style in test fixture (#4768) (overlookmotel) - e285903 linter: Clean up eslint/func_names (#4710) (DonIsaac) ### Testing - 8f2a566 linter: Ensure rule docs have valid syntax (#4644) (DonIsaac) - 4dd29db linter: Add fixer test for unicorn/no-zero-fractions (#4783) (heygsc) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>

github-actions bot added the A-linter Area - Linter label Aug 6, 2024

This was referenced Aug 6, 2024

feat(website): auto-generate rule docs pages #4640

Merged

test(linter): ensure rule docs have valid syntax #4644

Merged

DonIsaac force-pushed the don/08-04-test_linter_ensure_rule_docs_are_valid_markdown branch from be1445a to d787b05 Compare August 6, 2024 22:47

DonIsaac force-pushed the don/08-06-feat_linter_add_fix_emoji_to_rules_table branch from 6db8202 to df146ec Compare August 6, 2024 22:47

DonIsaac force-pushed the don/08-04-test_linter_ensure_rule_docs_are_valid_markdown branch from d787b05 to 957bea4 Compare August 9, 2024 20:00

DonIsaac force-pushed the don/08-06-feat_linter_add_fix_emoji_to_rules_table branch from df146ec to 6f8a2ef Compare August 9, 2024 20:00

Boshen force-pushed the don/08-04-test_linter_ensure_rule_docs_are_valid_markdown branch from 957bea4 to 5028db4 Compare August 10, 2024 00:17

Boshen force-pushed the don/08-06-feat_linter_add_fix_emoji_to_rules_table branch from 6f8a2ef to 20f427a Compare August 10, 2024 00:18

DonIsaac force-pushed the don/08-04-test_linter_ensure_rule_docs_are_valid_markdown branch from 5028db4 to 71f1b60 Compare August 10, 2024 02:04

DonIsaac force-pushed the don/08-06-feat_linter_add_fix_emoji_to_rules_table branch from 20f427a to bbb9185 Compare August 10, 2024 02:05

DonIsaac force-pushed the don/08-04-test_linter_ensure_rule_docs_are_valid_markdown branch from 71f1b60 to 68b4468 Compare August 10, 2024 03:42

DonIsaac force-pushed the don/08-06-feat_linter_add_fix_emoji_to_rules_table branch from bbb9185 to 18850eb Compare August 10, 2024 03:42

DonIsaac force-pushed the don/08-04-test_linter_ensure_rule_docs_are_valid_markdown branch from 68b4468 to c49cc99 Compare August 10, 2024 03:43

DonIsaac force-pushed the don/08-06-feat_linter_add_fix_emoji_to_rules_table branch from 18850eb to cc8c12f Compare August 10, 2024 03:43

DonIsaac force-pushed the don/08-04-test_linter_ensure_rule_docs_are_valid_markdown branch from 22f1f4e to 2afa0cf Compare August 10, 2024 04:56

DonIsaac force-pushed the don/08-06-feat_linter_add_fix_emoji_to_rules_table branch from cc8c12f to 4763b57 Compare August 10, 2024 04:56

DonIsaac force-pushed the don/08-04-test_linter_ensure_rule_docs_are_valid_markdown branch from 2afa0cf to 5d6d035 Compare August 10, 2024 05:00

DonIsaac force-pushed the don/08-06-feat_linter_add_fix_emoji_to_rules_table branch from 4763b57 to e47b77c Compare August 10, 2024 05:00

DonIsaac changed the base branch from don/08-04-test_linter_ensure_rule_docs_are_valid_markdown to graphite-base/4715 August 10, 2024 05:03

DonIsaac force-pushed the don/08-06-feat_linter_add_fix_emoji_to_rules_table branch from e47b77c to fd82f6e Compare August 10, 2024 05:07

DonIsaac force-pushed the graphite-base/4715 branch from 5d6d035 to 8f2a566 Compare August 10, 2024 05:07

DonIsaac changed the base branch from graphite-base/4715 to main August 10, 2024 05:08

DonIsaac force-pushed the don/08-06-feat_linter_add_fix_emoji_to_rules_table branch from fd82f6e to b8d5f76 Compare August 10, 2024 16:36

camc314 reviewed Aug 10, 2024

View reviewed changes

crates/oxc_linter/src/fixer/fix.rs Outdated Show resolved Hide resolved

DonIsaac force-pushed the don/08-06-feat_linter_add_fix_emoji_to_rules_table branch from b8d5f76 to 3f77f18 Compare August 10, 2024 19:04

DonIsaac mentioned this pull request Aug 10, 2024

feat: add rule doc pages oxc-project/oxc-project.github.io#165

Closed

DonIsaac added the C-enhancement Category - New feature or request label Aug 10, 2024

DonIsaac added the A-website label Aug 10, 2024

DonIsaac marked this pull request as ready for review August 10, 2024 19:40

DonIsaac requested review from camc314 and mysteryven August 10, 2024 19:40

DonIsaac force-pushed the don/08-06-feat_linter_add_fix_emoji_to_rules_table branch from 3f77f18 to eb2691e Compare August 10, 2024 20:18

DonIsaac changed the title ~~feat(linter): add fix emoji to rules table~~ feat(linter): add fix emoji to rules table and doc pages Aug 10, 2024

DonIsaac force-pushed the don/08-06-feat_linter_add_fix_emoji_to_rules_table branch from eb2691e to 4b77659 Compare August 10, 2024 20:52

camc314 reviewed Aug 10, 2024

View reviewed changes

tasks/website/src/linter/rules/test.rs Outdated Show resolved Hide resolved

camc314 approved these changes Aug 10, 2024

View reviewed changes

DonIsaac added the 0-merge Merge with Graphite Merge Queue label Aug 10, 2024

DonIsaac force-pushed the don/08-06-feat_linter_add_fix_emoji_to_rules_table branch from 8334871 to 3d40528 Compare August 10, 2024 22:50

graphite-app bot merged commit 3d40528 into main Aug 10, 2024
24 checks passed

graphite-app bot deleted the don/08-06-feat_linter_add_fix_emoji_to_rules_table branch August 10, 2024 22:54

oxc-bot mentioned this pull request Aug 12, 2024

Release oxlint v0.7.1 #4835

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(linter): add fix emoji to rules table and doc pages #4715

feat(linter): add fix emoji to rules table and doc pages #4715

DonIsaac commented Aug 6, 2024 •

edited

Loading

DonIsaac commented Aug 6, 2024 •

edited

Loading

codspeed-hq bot commented Aug 6, 2024 •

edited

Loading

camc314 left a comment

graphite-app bot commented Aug 10, 2024 •

edited

Loading

feat(linter): add fix emoji to rules table and doc pages #4715

feat(linter): add fix emoji to rules table and doc pages #4715

Conversation

DonIsaac commented Aug 6, 2024 • edited Loading

DonIsaac commented Aug 6, 2024 • edited Loading

codspeed-hq bot commented Aug 6, 2024 • edited Loading

CodSpeed Performance Report

Merging #4715 will not alter performance

Summary

camc314 left a comment

Choose a reason for hiding this comment

graphite-app bot commented Aug 10, 2024 • edited Loading

Merge activity

DonIsaac commented Aug 6, 2024 •

edited

Loading

DonIsaac commented Aug 6, 2024 •

edited

Loading

codspeed-hq bot commented Aug 6, 2024 •

edited

Loading

graphite-app bot commented Aug 10, 2024 •

edited

Loading