Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): generate .generated_ast_watch_list.yml #4737

Merged

Conversation

rzvxa
Copy link
Contributor

@rzvxa rzvxa commented Aug 7, 2024

closes #4699

I also did some reordering to the code so it is easier to follow.

@rzvxa rzvxa force-pushed the 08-07-chore_ci_generate_.generated_ast_watch_list.yml_ branch 3 times, most recently from 1da9a62 to daf63f7 Compare August 7, 2024 17:20
@rzvxa rzvxa requested review from overlookmotel and Boshen August 7, 2024 17:21
@rzvxa rzvxa marked this pull request as ready for review August 7, 2024 17:21
Copy link

graphite-app bot commented Aug 7, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link

codspeed-hq bot commented Aug 7, 2024

CodSpeed Performance Report

Merging #4737 will not alter performance

Comparing 08-07-chore_ci_generate_.generated_ast_watch_list.yml_ (aeed29f) with main (2218340)

Summary

✅ 29 untouched benchmarks

@overlookmotel
Copy link
Contributor

Not reviewed in full yet, but a couple of quick things:

  1. Is there a reason for . on start of .generated_ast_watch_list.yml? Can it be just generated_ast_watch_list.yml?
  2. Could you add a line break on end of the file?

@overlookmotel overlookmotel force-pushed the 08-07-refactor_ast_ast_codegen_use_generate_derive_for_implementing_getspan_and_getspanmut_traits branch from e07f720 to 2acb977 Compare August 7, 2024 17:44
@rzvxa rzvxa force-pushed the 08-07-refactor_ast_ast_codegen_use_generate_derive_for_implementing_getspan_and_getspanmut_traits branch from 2acb977 to ad4d955 Compare August 7, 2024 17:45
@overlookmotel overlookmotel force-pushed the 08-07-chore_ci_generate_.generated_ast_watch_list.yml_ branch from daf63f7 to b05c4e7 Compare August 7, 2024 17:45
@rzvxa
Copy link
Contributor Author

rzvxa commented Aug 7, 2024

1. Is there a reason for `.` on start of `.generated_ast_watch_list.yml`? Can it be just `generated_ast_watch_list.yml`?

It is a preference thing, Since the file is generated and we wish to forget about it; Having it hidden might be better.
Now that we always keep the CI filter updated there is no need to worry about this file. Think of it like a socket file or named pipe, It is just an identifier to pass data to our CI on behalf of the codegen.

2. Could you add a line break on end of the file?

Sure, I don't like the trailing newline but that's just me.

@github-actions github-actions bot added the A-ast Area - AST label Aug 7, 2024
@rzvxa rzvxa force-pushed the 08-07-chore_ci_generate_.generated_ast_watch_list.yml_ branch from b05c4e7 to a81339a Compare August 7, 2024 17:51
@rzvxa rzvxa marked this pull request as draft August 7, 2024 19:36
@rzvxa rzvxa marked this pull request as ready for review August 7, 2024 19:38
@overlookmotel overlookmotel force-pushed the 08-07-refactor_ast_ast_codegen_use_generate_derive_for_implementing_getspan_and_getspanmut_traits branch from ad4d955 to cdc8619 Compare August 7, 2024 20:35
@overlookmotel overlookmotel force-pushed the 08-07-chore_ci_generate_.generated_ast_watch_list.yml_ branch from 633fc51 to b57606c Compare August 7, 2024 20:36
@overlookmotel overlookmotel force-pushed the 08-07-refactor_ast_ast_codegen_use_generate_derive_for_implementing_getspan_and_getspanmut_traits branch from cdc8619 to 20fbe55 Compare August 7, 2024 21:26
@overlookmotel overlookmotel force-pushed the 08-07-chore_ci_generate_.generated_ast_watch_list.yml_ branch from b57606c to 8e6d11d Compare August 7, 2024 21:27
@rzvxa rzvxa force-pushed the 08-07-refactor_ast_ast_codegen_use_generate_derive_for_implementing_getspan_and_getspanmut_traits branch from 20fbe55 to 83a2fb7 Compare August 7, 2024 21:30
@rzvxa rzvxa force-pushed the 08-07-chore_ci_generate_.generated_ast_watch_list.yml_ branch 2 times, most recently from a3663f3 to 3e7fbfa Compare August 7, 2024 21:36
@overlookmotel overlookmotel changed the base branch from 08-07-refactor_ast_ast_codegen_use_generate_derive_for_implementing_getspan_and_getspanmut_traits to graphite-base/4737 August 7, 2024 22:07
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Aug 7, 2024
Copy link

graphite-app bot commented Aug 7, 2024

Merge activity

  • Aug 7, 6:08 PM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Aug 7, 6:09 PM EDT: overlookmotel added this pull request to the Graphite merge queue.
  • Aug 7, 6:18 PM EDT: overlookmotel merged this pull request with the Graphite merge queue.

@overlookmotel
Copy link
Contributor

overlookmotel commented Aug 7, 2024

  1. Is there a reason for . on start of .generated_ast_watch_list.yml? Can it be just generated_ast_watch_list.yml?

It is a preference thing, Since the file is generated and we wish to forget about it; Having it hidden might be better. Now that we always keep the CI filter updated there is no need to worry about this file. Think of it like a socket file or named pipe, It is just an identifier to pass data to our CI on behalf of the codegen.

OK cool.

  1. Could you add a line break on end of the file?

Sure, I don't like the trailing newline but that's just me.

It's a matter of taste, but it's the project's convention...

@overlookmotel overlookmotel changed the base branch from graphite-base/4737 to main August 7, 2024 22:10
closes #4699

I also did some reordering to the code so it is easier to follow.
@overlookmotel overlookmotel force-pushed the 08-07-chore_ci_generate_.generated_ast_watch_list.yml_ branch from 3e7fbfa to aeed29f Compare August 7, 2024 22:11
@graphite-app graphite-app bot merged commit aeed29f into main Aug 7, 2024
26 checks passed
@graphite-app graphite-app bot deleted the 08-07-chore_ci_generate_.generated_ast_watch_list.yml_ branch August 7, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-ast Area - AST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate CI filter for files included in oxc_ast_codegen
2 participants