-
-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): generate .generated_ast_watch_list.yml
#4737
chore(ci): generate .generated_ast_watch_list.yml
#4737
Conversation
1da9a62
to
daf63f7
Compare
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
CodSpeed Performance ReportMerging #4737 will not alter performanceComparing Summary
|
Not reviewed in full yet, but a couple of quick things:
|
e07f720
to
2acb977
Compare
2acb977
to
ad4d955
Compare
daf63f7
to
b05c4e7
Compare
It is a preference thing, Since the file is generated and we wish to forget about it; Having it hidden might be better.
Sure, |
b05c4e7
to
a81339a
Compare
ad4d955
to
cdc8619
Compare
633fc51
to
b57606c
Compare
cdc8619
to
20fbe55
Compare
b57606c
to
8e6d11d
Compare
20fbe55
to
83a2fb7
Compare
a3663f3
to
3e7fbfa
Compare
Merge activity
|
OK cool.
It's a matter of taste, but it's the project's convention... |
closes #4699 I also did some reordering to the code so it is easier to follow.
3e7fbfa
to
aeed29f
Compare
closes #4699
I also did some reordering to the code so it is easier to follow.