-
-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ast_codegen): declutter the main file. #4744
refactor(ast_codegen): declutter the main file. #4744
Conversation
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
CodSpeed Performance ReportMerging #4744 will not alter performanceComparing Summary
|
850ff38
to
eead990
Compare
eead990
to
9a94c20
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The diff is too large for me to easily understand what this PR is doing. I was only just starting to get my head around the codegen.
But it doesn't alter the generated output, so I'm going to merge it, and can suggest revisions later on if required.
Merge activity
|
9a94c20
to
abe8202
Compare
@overlookmotel It doesn't change any of the logic, Just moves the codegen related stuff to its own module so the main file only contains the bootstrapping code. |
same as #4741