Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ast_codegen): declutter the main file. #4744

Merged

Conversation

rzvxa
Copy link
Contributor

@rzvxa rzvxa commented Aug 7, 2024

same as #4741

Copy link

graphite-app bot commented Aug 7, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

rzvxa commented Aug 7, 2024

@rzvxa rzvxa marked this pull request as ready for review August 7, 2024 22:38
Copy link

codspeed-hq bot commented Aug 7, 2024

CodSpeed Performance Report

Merging #4744 will not alter performance

Comparing 08-08-refactor_ast_codegen_declutter_the_main_file (abe8202) with main (7345f68)

Summary

✅ 29 untouched benchmarks

@rzvxa rzvxa force-pushed the 08-08-refactor_ast_codegen_declutter_the_main_file branch 2 times, most recently from 850ff38 to eead990 Compare August 8, 2024 14:43
@rzvxa rzvxa force-pushed the 08-08-refactor_ast_codegen_declutter_the_main_file branch from eead990 to 9a94c20 Compare August 8, 2024 16:23
Copy link
Contributor

@overlookmotel overlookmotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff is too large for me to easily understand what this PR is doing. I was only just starting to get my head around the codegen.

But it doesn't alter the generated output, so I'm going to merge it, and can suggest revisions later on if required.

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Aug 8, 2024
Copy link

graphite-app bot commented Aug 8, 2024

Merge activity

  • Aug 8, 12:37 PM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Aug 8, 12:37 PM EDT: overlookmotel added this pull request to the Graphite merge queue.
  • Aug 8, 12:43 PM EDT: overlookmotel merged this pull request with the Graphite merge queue.

@overlookmotel overlookmotel force-pushed the 08-08-refactor_ast_codegen_declutter_the_main_file branch from 9a94c20 to abe8202 Compare August 8, 2024 16:38
@rzvxa
Copy link
Contributor Author

rzvxa commented Aug 8, 2024

@overlookmotel It doesn't change any of the logic, Just moves the codegen related stuff to its own module so the main file only contains the bootstrapping code.

@graphite-app graphite-app bot merged commit abe8202 into main Aug 8, 2024
24 checks passed
@graphite-app graphite-app bot deleted the 08-08-refactor_ast_codegen_declutter_the_main_file branch August 8, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants