Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linter): eslint-plugin-react jsx-props-no-spread-multi #4866

Merged
merged 9 commits into from
Aug 14, 2024

Conversation

Copy link

graphite-app bot commented Aug 13, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the A-linter Area - Linter label Aug 13, 2024
Copy link

codspeed-hq bot commented Aug 13, 2024

CodSpeed Performance Report

Merging #4866 will not alter performance

Comparing keita-hino:jsx-props-no-spread-multi (43558e1) with main (117ae36)

Summary

✅ 29 untouched benchmarks

@keita-hino keita-hino force-pushed the jsx-props-no-spread-multi branch from dce7419 to 7521f59 Compare August 13, 2024 06:57
@camc314 camc314 requested a review from DonIsaac August 13, 2024 08:16
@DonIsaac DonIsaac added the C-enhancement Category - New feature or request label Aug 13, 2024
@DonIsaac
Copy link
Contributor

@camc314 feel free to merge when you're happy.

@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Aug 14, 2024
Copy link

graphite-app bot commented Aug 14, 2024

Merge activity

  • Aug 14, 7:40 AM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Aug 14, 7:40 AM EDT: camc314 added this pull request to the Graphite merge queue.
  • Aug 14, 7:41 AM EDT: The Graphite merge queue couldn't merge this PR because it failed for an unknown reason (Stack merges are not currently supported for forked repositories. Please create a branch in the target repository in order to merge).

@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Aug 14, 2024
@DonIsaac
Copy link
Contributor

@camc314 I don't think Graphite's merge queue works for forks. You may need to merge manually when you're ready.

@camc314 camc314 merged commit 93ae1c7 into oxc-project:main Aug 14, 2024
27 checks passed
@camc314
Copy link
Contributor

camc314 commented Aug 14, 2024

@camc314 I don't think Graphite's merge queue works for forks. You may need to merge manually when you're ready.

thanks 😅

@keita-hino
Copy link
Contributor Author

@camc314 @DonIsaac Thank you for the review!

@keita-hino keita-hino deleted the jsx-props-no-spread-multi branch August 14, 2024 15:54
@oxc-bot oxc-bot mentioned this pull request Aug 15, 2024
Boshen added a commit that referenced this pull request Aug 15, 2024
## [0.7.2] - 2024-08-15

### Features

- 97e38cd linter: Add fixer for unicorn/prefer-optional-catch-binding
(#4867) (heygsc)
- 93ae1c7 linter: Eslint-plugin-react jsx-props-no-spread-multi (#4866)
(keita hino)
- 0a23610 linter: Add fixer for unicorn/prefer-array-flat-map (#4844)
(heygsc)
- 13c7b1b linter/jsx-a11y: Add fixer for aria-unsupported-elements
(#4854) (DonIsaac)
- a6195a6 linter/jsx-a11y: Add fixer for anchor-has-content (#4852)
(DonIsaac)
- 4d28d03 task/website: Support render `subschemas.all_of` (#4800)
(mysteryven)

### Bug Fixes

- 21f5762 codegen: Minify large numbers (#4889) (Boshen)
- a08d7a7 linter/jsx-a11y: Reduce false negatives for html-has-lang
(#4855) (DonIsaac)
- a81ce3a linter/no-unused-vars: Do not delete function expressions when
fixing (#4848) (DonIsaac)

### Documentation

- 955a4b4 oxlint: Improve cli doc regarding fix and `-D all` (Boshen)

### Refactor

- 56f033c linter: Improve diagnostics for several jsx-a11y rules (#4853)
(DonIsaac)
- c53c210 linter/no-unused-vars: Split fixer logic into multiple files
(#4847) (DonIsaac)

Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants