fix(transformer/typescript): typescript syntax within SimpleAssignmentTarget with MemberExpressions is not stripped

[Dunqing]

close: #4870

I added the move_identifier_reference and move_member_expression methods used to take ownership in ast_builder_impl. This way can let us get rid of ast.copy.

Another possible approach is to add get_expression_owner to SimpleAssignmentTarget and a get_inner_expression_owner method to Expression. And add an into_xxxxx method for inherit_variants macro

The implementation looks like this

let Some(expression) = self.get_expression_owner() else { return; }
match expr.get_inner_expression_owner() {
    Expression::Identifier(ident) => {
        *target = self.ctx.ast.simple_assignment_target_from_identifier_reference(ident);
    }
    inner_expr @ match_member_expression!(Expression) => {
        *target = SimpleAssignmentTarget::from(
            inner_expr.into_member_expression()
        );
    }
    _ => (),
}

[Dunqing]

• fix(transformer/typescript): typescript syntax within SimpleAssignmentTarget with MemberExpressions is not stripped #4920 👈
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Dunqing and the rest of your teammates on Graphite

[codspeed-hq]

CodSpeed Performance Report

Merging #4920 will not alter performance

_{Comparing 08-16-feat_transformer_typescript_typescript_syntax_within_simpleassignmenttarget_with_memberexpressions_is_not_stripped (248a757) with main (508644a)}

Summary

✅ 29 untouched benchmarks

[graphite-app]

Merge activity

• Aug 16, 1:04 AM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Aug 16, 1:04 AM EDT: Boshen added this pull request to the Graphite merge queue.
• Aug 16, 1:08 AM EDT: Boshen merged this pull request with the Graphite merge queue.